feat(error-tracking): link exceptions to active spans#743
Merged
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "fix(error-tracking): keep telemetry help..." | Re-trigger Greptile |
Contributor
posthog-python Compliance ReportDate: 2026-07-16 10:12:18 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Exceptions captured inside instrumented code currently lose their active OpenTelemetry context, which prevents correlation with the trace and span where the exception occurred.
capture_exceptionnow reads a valid active OpenTelemetry span when the optional dependency is available and adds zero-padded$trace_idand$span_idproperties. Explicitly supplied properties retain precedence, and exception capture remains unchanged when OpenTelemetry is absent or no valid span is active.💚 How did you test it?
uv run --extra test pytest posthog/test/test_client.py -k 'capture_exception' --verbose --timeout=30uv run ruff format --check . && uv run ruff check .uv run --extra dev --extra test mypy --no-site-packages --config-file mypy.ini . | uv run --extra dev mypy-baseline filteruv run make public_api_checkuv run python -W error -c "import posthog"📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Implemented with the Pi coding agent. The active span is read through a lazy OpenTelemetry import so the SDK keeps its optional dependency behavior. Only valid contexts are emitted, identifiers use standard fixed-width lowercase hexadecimal formatting, and caller-supplied values take precedence. A focused branch was created from current
mainto avoid including unrelated local error-tracking work.