Fix: don't warn about expired token immediately on VS Code startup#332
Open
Mosh-K wants to merge 1 commit into
Open
Fix: don't warn about expired token immediately on VS Code startup#332Mosh-K wants to merge 1 commit into
Mosh-K wants to merge 1 commit into
Conversation
Only show the token-expiration notification when the token was valid at some point during the current session and then went stale, instead of firing immediately whenever a stale connection from a prior session is detected on activation (the common case, since tokens outlive most gaps between VS Code restarts).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only show the token-expiration notification when the token was valid at some point during the current session and then went stale, instead of firing immediately whenever a stale connection from a prior session is detected on activation (the common case, since tokens outlive most gaps between VS Code restarts).
Follow-up to #287 — the background token-expiration check fires the moment a stale-from-before-restart connection is detected, so it ends up warning on nearly every VS Code startup rather than just in-session expirations.