Skip to content

#591, #561 fix: update Dataverse hostname pattern to include new regions and improve URL validation#596

Merged
Power-Maverick merged 1 commit into
PowerPlatformToolBox:devfrom
cyco77:feature/api-crm-cn
Jul 22, 2026
Merged

#591, #561 fix: update Dataverse hostname pattern to include new regions and improve URL validation#596
Power-Maverick merged 1 commit into
PowerPlatformToolBox:devfrom
cyco77:feature/api-crm-cn

Conversation

@cyco77

@cyco77 cyco77 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

added validation for urls like api.crm().dynamics.com and crm().dynamics.cn

Type of change

  • New feature
  • Bug fix
  • Refactor (no functional change)
  • Documentation
  • Chore / maintenance (dependency update, build, config)
  • Test addition / improvement

Changes

just changed REGEX for URL validation

Architecture checklist

Packages (types & validation)

  • Not applicable — no changes to packages/

If you did change a package:

  • @pptb/types (types): type definitions updated and version bumped in packages/types/package.json
  • @pptb/validate (validation): validation rules updated and version bumped in packages/validation/package.json

Code quality

  • pnpm run typecheck passes with 0 errors (warnings are acceptable)
  • pnpm run lint passes with 0 errors (warnings are acceptable)
  • pnpm run build completes successfully

Testing

  • pnpm run test:unit passes (for changes to src/main/, src/common/, or src/renderer/ utilities)
  • pnpm run test:e2e passes (for UI / navigation / end-to-end flows)
  • Manually tested in the running app (pnpm run dev)

Scenario tested:

Screenshots / recordings

Breaking changes

  • No breaking changes
  • Yes — describe impact and migration path below:

Reviewer notes

  • I have added appropriate unit and/or e2e tests for this change
  • I have resolved all GitHub Copilot review comments
  • I have followed the guidelines in CONTRIBUTING.md

…rse hostname pattern to include new regions and improve URL validation
@Power-Maverick Power-Maverick changed the title #591, #561 fix: update Dataverse hostname pattern to include new regi… #591, #561 fix: update Dataverse hostname pattern to include new regions and improve URL validation Jul 22, 2026
@Power-Maverick

Copy link
Copy Markdown
Contributor

@cyco77 please edit the PR description and select all the applicable checkboxes. Make sure PR Validation workflow is a success

@Power-Maverick
Power-Maverick self-requested a review July 22, 2026 08:59
@Power-Maverick
Power-Maverick merged commit 565a1a3 into PowerPlatformToolBox:dev Jul 22, 2026
4 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants