feat: per-user concurrency limit - #757
Merged
greatest0fallt1me merged 1 commit intoJul 29, 2026
Merged
Conversation
Cap the number of in-flight concurrent requests per user/IP across all
/api routes to prevent a single identity from exhausting the thread pool
or DB connection pool.
Changes:
- src/middleware/perUserConcurrency.ts (new): createPerUserConcurrencyMiddleware
factory + perUserConcurrency singleton. Uses an in-process Map<string,number>
counter; decrements on res finish/close; returns HTTP 429 with
Retry-After: 1 and standardised error envelope on exceed.
- src/config/env-schema.ts: MAX_CONCURRENT_REQUESTS_PER_USER env var (default 10)
- src/index.ts: app.use('/api', perUserConcurrency) before all route handlers
- .env.example: document MAX_CONCURRENT_REQUESTS_PER_USER
- README.md: Per-user concurrency limit section
- tests/perUserConcurrency.test.ts: 22 tests, 100% line coverage, 93% branch
Closes Predictify-org#320
|
@shinorh247 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
All good — merging. 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cap the number of in-flight concurrent requests per user/IP across all /api routes to prevent a single identity from exhausting the thread pool or DB connection pool.
Changes:
Closes #320