feat(metrics): add Prometheus latency histogram for /api/markets - #869
Merged
greatest0fallt1me merged 2 commits intoJul 29, 2026
Merged
Conversation
|
@MJ-RWA Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Clean PR — merged 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Prometheus request latency instrumentation for the
/api/marketsendpoint using aprom-clientHistogram with explicit buckets and route labels. This improves observability by enabling latency tracking and performance analysis while preserving existing endpoint behavior.Closes #28
Changes Made
Added a Prometheus Histogram for
/api/marketsrequest latency.Registered the histogram in the metrics registry using the project's existing metrics infrastructure.
Configured explicit latency buckets for accurate request duration measurement.
Added route labels (and other standard labels where applicable) to support filtering and aggregation.
Instrumented the
/api/marketsendpoint to record request latency for both successful and failed requests.Prevented duplicate metric registration to ensure compatibility with repeated initialization and test environments.
Preserved standardized error handling and existing API behavior.
Integrated with the project's structured logging and correlation ID conventions where applicable.
Added focused tests covering:
Updated relevant documentation to describe the new latency metric.
Testing
/api/markets.Notes
This change is fully backward compatible and introduces no API-breaking changes. It adds internal Prometheus latency metrics to improve monitoring and operational visibility for the
/api/marketsendpoint.Closes: #602