fix(flashlight): export PRESTAFLOW_FO_URL instead of PRESTAFLOW_PS_URL#2
Merged
Conversation
…ad of PRESTAFLOW_PS_URL
The PHP library reads PRESTAFLOW_FO_URL for the front-office URL and
derives PRESTAFLOW_BO_URL as ${PRESTAFLOW_FO_URL}admin-dev/ when
PRESTAFLOW_BO_URL is not set (see TestsSuite.php:715-720). Exporting
PRESTAFLOW_PS_URL had no effect — the library did not read it.
The trailing slash is required so BO defaulting yields
http://localhost:8000/admin-dev/ (matching Flashlight's admin route)
instead of http://localhost:8000admin-dev/.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The v2 rewrite exports
PRESTAFLOW_PS_URL=http://localhost:<port>when Flashlight is up, but the PHP library readsPRESTAFLOW_FO_URL(and derives BO as${FO_URL}admin-dev/) — seeTestsSuite.php:715-720.Result: the exported env var was ignored, tests kept hitting whatever URL the consuming repo's
.envpointed at (or the built-in localhost default).Fix
Export
PRESTAFLOW_FO_URLwith a trailing slash so BO defaulting yieldshttp://localhost:8000/admin-dev/— matching Flashlight's admin route.Test plan
npm run lintcleannpm test41/41 pass (no test change needed — orchestration is not unit-tested)dist/rebuiltPrestaFlow/prestaflow-prestashop— coming in a follow-up branch🤖 Generated with Claude Code