fix(flashlight): add MariaDB sidecar + bump readiness timeout to 240s#4
Merged
Conversation
Root cause of 'Flashlight not ready after 120000ms': Flashlight does NOT embed MySQL — it depends on an external MariaDB service via depends_on: condition: service_healthy. Without it, PrestaShop waits forever for a DB it never gets. Changes: - compose-template: add mysql service (mariadb:lts) with the exact healthcheck the Flashlight docs prescribe (healthcheck.sh --connect, 10s interval, 5 retries). PrestaShop now waits for MySQL health before starting. - docker: waitFor timeout raised from 120s to 240s. Cold-boot on GH Actions runners includes: MySQL image pull + healthcheck loop (~30-60s) + PS install (~60-90s). 120s was systematically hitting the cliff. Ref: https://github.com/PrestaShop/prestashop-flashlight/blob/main/examples/basic-example/docker-compose.yml Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause of
Flashlight not ready after 120000msPrestaShop Flashlightdoes not embed MySQL. It depends on an external MariaDB service viadepends_on: condition: service_healthy. Without that sidecar, PrestaShop waits forever for a DB it never gets and never binds to :80.Confirmed against the reference basic-example docker-compose.yml.
Changes
mysqlservice (mariadb:lts) with the healthcheck the Flashlight docs prescribe (healthcheck.sh --connect, 10s interval, 5 retries). PrestaShop now waits for MySQL to be healthy before starting viadepends_on.waitFortimeout raised 120s → 240s. Cold-boot on GH Actions includes MySQL image pull (~10s) + healthcheck loop (~30–60s) + PS install (~60–90s). 120s was systematically hitting the cliff.Test plan
http://localhost:8000.🤖 Generated with Claude Code