Skip to content

fix: disable wrong e2e tests temporarily#381

Merged
raven-wing merged 1 commit into
Problematy:mainfrom
raven-wing:fix_e2e
Jul 6, 2026
Merged

fix: disable wrong e2e tests temporarily#381
raven-wing merged 1 commit into
Problematy:mainfrom
raven-wing:fix_e2e

Conversation

@raven-wing

@raven-wing raven-wing commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Updated automated testing so the end-to-end test job can fail without causing the entire workflow to fail.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The GitHub Actions workflow file for tests was modified to add continue-on-error: true to the e2e-tests job, allowing that job to fail without failing the overall workflow run.

Changes

CI Workflow Update

Layer / File(s) Summary
e2e-tests failure tolerance
.github/workflows/tests.yml
Added continue-on-error: true to the e2e-tests job so its failures no longer fail the overall workflow.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • Problematy/goodmap#274: Also modifies configuration of the same e2e-tests job in .github/workflows/tests.yml.

Poem

A hop, a flag, a workflow's sigh,
"continue-on-error" lets tests pass by.
No more halting the whole parade,
Just one small line, a rabbit's trade. 🐇✅

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the change: it temporarily relaxes the e2e test job so failures don't fail the workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/tests.yml (1)

96-107: 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win

continue-on-error can’t be set on this reusable-workflow job.
e2e-tests uses uses:, so GitHub Actions rejects continue-on-error here; the workflow won’t validate, and the failure handling has to move into the called workflow or downstream job gating.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/tests.yml around lines 96 - 107, The reusable-workflow job
e2e-tests is invalid because continue-on-error is set on a job that uses a
reusable workflow via uses:. Remove continue-on-error from this job and, if you
still need non-blocking behavior, handle failure tolerance inside the called
workflow or by adding downstream job gating around e2e-tests in the workflow
definition.

Source: Linters/SAST tools

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In @.github/workflows/tests.yml:
- Around line 96-107: The reusable-workflow job e2e-tests is invalid because
continue-on-error is set on a job that uses a reusable workflow via uses:.
Remove continue-on-error from this job and, if you still need non-blocking
behavior, handle failure tolerance inside the called workflow or by adding
downstream job gating around e2e-tests in the workflow definition.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 79ab9c63-4c5c-4885-bdc5-8b519d496404

📥 Commits

Reviewing files that changed from the base of the PR and between 27cbf5b and f6cd42b.

📒 Files selected for processing (1)
  • .github/workflows/tests.yml

@raven-wing raven-wing merged commit e73c849 into Problematy:main Jul 6, 2026
6 checks passed
@raven-wing raven-wing deleted the fix_e2e branch July 6, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant