perf: cache per-repo install status instead of per-frame disk I/O#48
Merged
Conversation
The grid stat'ed the filesystem for every card on every redraw (installed_app_path + a version-file read), and the detail footer did the same. Install state only changes at catalog load, download completion and uninstall: a cache refreshed exactly there now feeds the views, which no longer touch the disk per frame. (The detail Launch button keeps resolving the real path once per render - it needs the PathBuf, and it is a single page.) Also collapses a match-arm guard in the desktop-entry scan skip that the just-released clippy 1.97 rejects (collapsible_match) - CI runs resolve the stable toolchain at run time, so every future run would have failed on it, the pending release included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexte (audit 2026-07-20, P4)
installed_app_path+ lecture du fichier de version), pareil pour le footer du détail. L'état d'install ne change qu'au chargement du catalogue, à la complétion d'un download et à l'uninstall : un cache rafraîchi exactement là nourrit les vues.collapsible_match) qui vient de sortir - les CI résolvent la toolchain stable au run, donc toutes les prochaines exécutions auraient échoué dessus (c'est ce qui a fait rougir la chore(deps): bump zip from 2.4.2 to 8.6.0 #44 après rebase), release incluse.Validation
104 tests verts, clippy 0 (toolchain locale + le lint 1.97 traité), fmt OK.