[FIX] Project.write_json() update outputs instead of overriding them#431
Open
Gautzilla wants to merge 5 commits into
Open
[FIX] Project.write_json() update outputs instead of overriding them#431Gautzilla wants to merge 5 commits into
Gautzilla wants to merge 5 commits into
Conversation
Collaborator
|
coverage: 98.981% (+0.009%) from 98.972% — Gautzilla:fix/project-write-json into Project-OSmOSE:main |
mathieudpnt
requested changes
Jul 7, 2026
mathieudpnt
left a comment
mathieudpnt
left a comment
Contributor
There was a problem hiding this comment.
This worked for me as i successfully launched 13 Transforms simultenaously 🥇
Also, would be nice to have the transforms of a
Projectinstance in alphanumerical order 👼
It would be nice to sort alphanumericaly the Transform names though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a project's JSON was modified by another process while the script was running (e.g. if two transforms are run simultaneously in different jobs), the latter overwrote the former
This PR should fix it by parsing the outputs in the project's JSON and joining them with the outputs of the project in the current shell.
The only remaining thing that could be messy if if someones runs simultaneously 2 transform that have the same name: the latter might still overwrite the former, but I'm not sure what's the best way of avoiding that (other than the user not doing that mistake!)
This PR resolves #405