-
Notifications
You must be signed in to change notification settings - Fork 10
Gemini: Toggleable Inference Routing #982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Prajna1999
wants to merge
9
commits into
main
Choose a base branch
from
feat/gemini-default-routing-switch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1a725e3
feat: default google credes
Prajna1999 84badf7
fix: add trailing slash to the POST msvc guardrails call
Prajna1999 2f74288
fix: tets cases and routing at platform level for vertex
Prajna1999 fa54a02
Merge branch 'main' into feat/gemini-default-routing-switch
Prajna1999 04ca240
fix: default vertex init
Prajna1999 a7c0062
Merge remote-tracking branch 'refs/remotes/origin/feat/gemini-default…
Prajna1999 c490b46
fix: two smol comments
Prajna1999 2adb86a
Merge branch 'main' into feat/gemini-default-routing-switch
Prajna1999 dc11e7b
non-opinionated gemini default model
Prajna1999 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major
Aistudio platform fallback contradicts PR's stated "no fallback" behavior.
The PR objectives state that for the
aistudioroute, missing user credentials should raise an error "and there are no platform-level fallbacks." But thiscreate_clientfalls back tosettings.GEMINI_API_KEYwhenevercredentials["api_key"]is absent, andtest_google_aistudio_route_falls_back_to_platform_defaultsexplicitly asserts this fallback succeeds for platform-routed"google"traffic. Please confirm which behavior is intended — if the PR description is authoritative, this fallback (and its supporting test) should be removed/gated so platform-routed aistudio without stored credentials raises instead of silently using a shared platform key.🤖 Prompt for AI Agents