Skip to content

fix(auth): Prevent cached stale auth redirects in middleware#244

Merged
Ayush8923 merged 1 commit into
mainfrom
fix/no-cache-stale-auth
Jul 3, 2026
Merged

fix(auth): Prevent cached stale auth redirects in middleware#244
Ayush8923 merged 1 commit into
mainfrom
fix/no-cache-stale-auth

Conversation

@Ayush8923

@Ayush8923 Ayush8923 commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

Auth-gating middleware responses were cacheable, so the browser/CDN could replay a stale redirect after the underlying auth cookies changed. The most visible symptom: after logging out (or when the API key cookie was cleared) the user still couldn't reach /keystore, it kept redirecting to /chat until the site cache was manually cleared.

Checklist

Before submitting a pull request, please ensure that you mark these task.

  • Ran npm run dev and npm run build in the repository root and test.
  • If you've fixed a bug or added code that is tested

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Ayush8923, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0e6a54b2-7938-4d4b-a216-0cab5c103203

📥 Commits

Reviewing files that changed from the base of the PR and between 9517392 and a7a5948.

📒 Files selected for processing (1)
  • middleware.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/no-cache-stale-auth

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot changed the title fix(auth): no cache stale issue fix fix(auth): Address stale cache issue Jul 3, 2026
@Ayush8923 Ayush8923 requested a review from vprashrex July 3, 2026 08:25
@Ayush8923 Ayush8923 self-assigned this Jul 3, 2026
@Ayush8923 Ayush8923 changed the title fix(auth): Address stale cache issue fix(auth): Prevent cached stale auth redirects in middleware Jul 3, 2026
@Ayush8923 Ayush8923 merged commit 0829826 into main Jul 3, 2026
3 checks passed
@Ayush8923 Ayush8923 deleted the fix/no-cache-stale-auth branch July 3, 2026 08:27
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 0.3.0-main.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants