fix(packaging): ship linopy.remote and linopy.persistent in the wheel#865
Merged
Conversation
`[tool.setuptools.packages.find]` include patterns are exact per level, so `include = ["linopy"]` matched only the top-level package and dropped the `linopy.remote` and `linopy.persistent` subpackages from built wheels. Since `linopy/__init__.py` imports `from linopy.remote import RemoteHandler` unconditionally, `import linopy` fails outright on a clean wheel install. Add `"linopy.*"` so subpackages are discovered. Closes #864 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #864.
Note
The following content was generated by AI and verified locally.
[tool.setuptools.packages.find]include patterns are exact per level, soinclude = ["linopy"]matched only the top-level package and droppedlinopy.remoteandlinopy.persistentfrom built wheels.This is worse than latent:
linopy/__init__.pydoes an unconditionalfrom linopy.remote import RemoteHandler, soimport linopyfails outright on a clean wheel install. It doesn't surface in development because editable/source installs expose the whole tree regardless.Fix: add
"linopy.*"so subpackages are discovered.Verification (uv build wheel contents)
Before (
include = ["linopy"]):After, the built wheel ships both subpackages: