Split MSan depends CI job#67
Open
kiwidream wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split the existing
MSan, dependsCI matrix entry into two smaller jobs targeting the same MSan environment:MSan, depends, unit testsMSan, depends, functional testsThe split is selected with
MSAN_CI_PARTin the MSan env file. The default unset behavior remains unchanged for local/manual use. The unit job skips functional tests and non-test executables, while the functional job skipsBUILD_TESTSbut keeps the functional-test tools enabled so tool-dependent functional coverage is not silently skipped.Testing
Checks run:
bash -n ci/test/00_setup_env_native_msan.sh ci/test/03_test_script.sh ci/test/00_setup_env.sh.github/workflows/ci.ymlwith Ruby YAML and PyYAML.git diff --check origin/main...HEADMSAN_CI_PARTenv resolution for default,unit, andfunctionalpaths throughci/test/00_setup_env.sh.Target Branch
mainor a maintainer-requested release branch such as0.1.x.Risk / Review Notes
Notes: CI behavior changes only. Runtime consensus, wallet, P2P, script, crypto, and release code are unchanged.
Docs / Process Impact
Choose exactly one:
libbitcoinpqc Subtree Checklist (if
src/libbitcoinpqcchanged)N/A;
src/libbitcoinpqcis unchanged.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Note
Low Risk
CI scheduling and build flags only; no runtime product code changes. Slightly higher operational risk if one split job misconfigures test toggles and silently drops coverage.
Overview
Splits the single MSan depends CI job into two parallel matrix jobs so unit and functional MSan coverage run separately with smaller, targeted builds.
The workflow passes
MSAN_CI timeout-minutesfrom the matrix into the job env.00_setup_env_native_msan.shbranches onMSAN_CI_PART: the unit job setsci_native_msan_unit, runs unit tests only, usesGOAL=all, and turns off GUI/daemon/CLI and other non-test binaries; the functional job setsci_native_msan_functional, skips unit tests, disablesBUILD_TESTS, and keepsqbit-tx,qbit-util, andqbit-walletfor functional coverage. UnsetMSAN_CI_PARTkeeps the prior combined behavior for local runs.The Set mmap_rnd_bits step now applies to any container whose name starts with
ci_native_msan, not only the legacy single name.Reviewed by Cursor Bugbot for commit 9a78714. Bugbot is set up for automated code reviews on this repo. Configure here.