[codex] Add DCA runtime settings#105
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e7a17fa36d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| dca_mode=_optional_dca_mode_env("DCA_MODE"), | ||
| dca_base_investment_usd=_optional_positive_float_env("DCA_BASE_INVESTMENT_USD"), |
There was a problem hiding this comment.
Add DCA vars to Cloud Run env sync
When DCA settings are configured through this repo's Cloud Run deploy workflow, these new variables won't be propagated: I checked .github/workflows/sync-cloud-run-env.yml, and it only imports GitHub vars that are listed in the job env: block and then passed through add_optional_env; DCA_MODE and DCA_BASE_INVESTMENT_USD are missing from both places. As a result, setting those repository variables for nasdaq_sp500_smart_dca or ibit_smart_dca leaves Cloud Run running with the strategy defaults/old environment after deploy, so the new runtime controls added here do not take effect in the managed deployment path.
Useful? React with 👍 / 👎.
Summary
Validation
Note