Skip to content

[codex] Add DCA runtime settings#105

Merged
Pigbibi merged 1 commit into
mainfrom
dca-runtime-settings
Jun 18, 2026
Merged

[codex] Add DCA runtime settings#105
Pigbibi merged 1 commit into
mainfrom
dca-runtime-settings

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Parse DCA_MODE and DCA_BASE_INVESTMENT_USD from runtime settings.
  • Map fixed/smart DCA settings to UsEquityStrategies runtime config.
  • Bump UsEquityStrategies dependency to 361338f60900182e3be535cd5fd2be2b9a07b422 in requirements and pyproject.

Validation

  • python3 -m py_compile runtime_config_support.py strategy_runtime.py tests/test_strategy_runtime.py
  • lightweight stub import check for _build_runtime_overrides DCA mapping

Note

  • Full local pytest run is blocked on this VPS by missing pytest/quant_platform_kit dependencies.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e7a17fa36d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread runtime_config_support.py
Comment on lines +177 to +178
dca_mode=_optional_dca_mode_env("DCA_MODE"),
dca_base_investment_usd=_optional_positive_float_env("DCA_BASE_INVESTMENT_USD"),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add DCA vars to Cloud Run env sync

When DCA settings are configured through this repo's Cloud Run deploy workflow, these new variables won't be propagated: I checked .github/workflows/sync-cloud-run-env.yml, and it only imports GitHub vars that are listed in the job env: block and then passed through add_optional_env; DCA_MODE and DCA_BASE_INVESTMENT_USD are missing from both places. As a result, setting those repository variables for nasdaq_sp500_smart_dca or ibit_smart_dca leaves Cloud Run running with the strategy defaults/old environment after deploy, so the new runtime controls added here do not take effect in the managed deployment path.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit 3eb8e8d into main Jun 18, 2026
1 check passed
@Pigbibi Pigbibi deleted the dca-runtime-settings branch June 18, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant