Skip to content

Add localized strategy display names to status rows#101

Merged
Pigbibi merged 1 commit into
mainfrom
codex/localized-strategy-status-names
Jun 18, 2026
Merged

Add localized strategy display names to status rows#101
Pigbibi merged 1 commit into
mainfrom
codex/localized-strategy-status-names

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add optional localized strategy display names to catalog/status/profile rows
  • expose zh display name for the mega-cap Top50 strategy via shared localization
  • cover localized display name propagation in strategy helper tests

Tests

  • PYTHONPATH=src python -m pytest tests/test_strategies.py -q
  • python -m py_compile src/quant_platform_kit/common/strategies.py src/quant_platform_kit/common/notification_localization.py

@Pigbibi Pigbibi merged commit 2a711ad into main Jun 18, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/localized-strategy-status-names branch June 18, 2026 07:50

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c27f385954

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

canonical_profile: str
display_name: str
description: str
localized_display_names: Mapping[str, str] = field(default_factory=dict)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve positional aliases in StrategyMetadata

Callers that still use the pre-existing positional form StrategyMetadata(profile, name, desc, aliases) now have the aliases tuple bound to localized_display_names instead of aliases. In that scenario alias resolution silently loses the aliases, and the new row builders that call _localized_display_name_fields() raise AttributeError because the tuple has no .get(). Add the new optional field after the existing fields or make it keyword-only to avoid breaking the public constructor shape.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant