Add localized strategy display names to status rows#101
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c27f385954
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| canonical_profile: str | ||
| display_name: str | ||
| description: str | ||
| localized_display_names: Mapping[str, str] = field(default_factory=dict) |
There was a problem hiding this comment.
Preserve positional aliases in StrategyMetadata
Callers that still use the pre-existing positional form StrategyMetadata(profile, name, desc, aliases) now have the aliases tuple bound to localized_display_names instead of aliases. In that scenario alias resolution silently loses the aliases, and the new row builders that call _localized_display_name_fields() raise AttributeError because the tuple has no .get(). Add the new optional field after the existing fields or make it keyword-only to avoid breaking the public constructor shape.
Useful? React with 👍 / 👎.
Summary
Tests