Skip to content

[codex] Delegate strategy plugin manual alerts#98

Merged
Pigbibi merged 1 commit into
mainfrom
codex/unified-plugin-notification
Jun 16, 2026
Merged

[codex] Delegate strategy plugin manual alerts#98
Pigbibi merged 1 commit into
mainfrom
codex/unified-plugin-notification

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • skip strategy-mounted plugin-bot alerts when the artifact delegates manual review to a notification target
  • localize notification-target labels for shared plugin alert messages
  • document the delegated notification boundary

Validation

  • PYTHONPATH=src python -m pytest tests/test_strategy_plugins.py

@Pigbibi Pigbibi merged commit 5ee38a0 into main Jun 16, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/unified-plugin-notification branch June 16, 2026 18:41

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3838bf8968

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +936 to +937
if _is_strategy_manual_review_notification_delegated(signal):
return False

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restrict delegated suppression to manual-review alerts

When a strategy artifact has manual_review_notification_delegated=true, this early return runs before the normal escalation predicates, so a later blocked/blocked signal or other non-manual-review alert with the delegation flag still set produces no plugin-bot message. The contract keeps blocked cases in the plugin-alert stream, so this should only suppress the specific delegated manual-review route/action rather than every alert from that artifact.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant