Skip to content

[codex] Humanize plugin alert messages#99

Merged
Pigbibi merged 1 commit into
mainfrom
codex/humanize-plugin-alerts
Jun 16, 2026
Merged

[codex] Humanize plugin alert messages#99
Pigbibi merged 1 commit into
mainfrom
codex/humanize-plugin-alerts

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • rewrite strategy plugin alert i18n so notices answer the operator questions: what happened, whether it is crisis/opportunity, and what to do next
  • localize market_regime_notification as a user-facing unified market-regime notification target
  • add structured situation/recommendation generation from plugin route/action/reason labels while keeping raw ids in metadata for audit and dedupe

Validation

  • PYTHONPATH=src python -m pytest tests/test_strategy_plugins.py
  • git diff --check

@Pigbibi Pigbibi merged commit 0e8c734 into main Jun 16, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/humanize-plugin-alerts branch June 16, 2026 19:10

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 84443f864f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1090 to +1092
log_record = payload.get("log_record")
if isinstance(log_record, Mapping):
reason_codes = log_record.get("reason_codes")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Honor top-level reason_codes in alert summaries

When a plugin artifact supplies machine reason_codes at the top level (the runtime contract lists them alongside canonical_route and suggested_action), this new fallback never reads them; it only checks log_record.reason_codes and position_control.reason_codes. Those alerts will say no explicit reason provided, so operators lose the trigger reason unless the artifact duplicates the codes into one of these nested sections. Please check payload.get("reason_codes") before the nested fallbacks.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant