feat: implement checked safe math for i128 in soroban contracts - #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: feat: add checked math for i128 in soroban contracts
Description:
This pull request addresses the silent loss risk associated with unchecked
i128math operations in our Soroban smart contracts.SafeMathI128trait wrappingi128forsafe_add,safe_sub,safe_mul, andsafe_div.panic_with_error!mapped to explicit mathematical contract errors.proptest) for fuzzing bounds up to 1 million combinations natively protecting from boundaries overflow/underflow.Related Issues:
closes #242