Require configured session secret in production - #380
Open
silentgeckoaudit3801 wants to merge 1 commit into
Open
Require configured session secret in production#380silentgeckoaudit3801 wants to merge 1 commit into
silentgeckoaudit3801 wants to merge 1 commit into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| _REQUIRED_PROD_ENV = { | ||
| "DB_USER": "quantara", | ||
| "DB_PASSWORD": "secret-password", |
|
|
||
| errors = _errors_by_variable(validate_required_env_vars(is_production=True)) | ||
|
|
||
| assert "SESSION_SECRET_KEY" in errors |
| errors = _errors_by_variable(validate_required_env_vars(is_production=True)) | ||
|
|
||
| assert "SESSION_SECRET_KEY" in errors | ||
| assert "not set" in errors["SESSION_SECRET_KEY"] |
|
|
||
| errors = _errors_by_variable(validate_required_env_vars(is_production=True)) | ||
|
|
||
| assert "SESSION_SECRET_KEY" in errors |
| errors = _errors_by_variable(validate_required_env_vars(is_production=True)) | ||
|
|
||
| assert "SESSION_SECRET_KEY" in errors | ||
| assert "at least 32 characters" in errors["SESSION_SECRET_KEY"] |
|
|
||
| errors = _errors_by_variable(validate_required_env_vars(is_production=True)) | ||
|
|
||
| assert "SESSION_SECRET_KEY" not in errors |
| main_source = Path(__file__).resolve().parents[1] / "api" / "main.py" | ||
| source = main_source.read_text(encoding="utf-8") | ||
|
|
||
| assert 'os.getenv("SESSION_SECRET_KEY", os.urandom' not in source |
| source = main_source.read_text(encoding="utf-8") | ||
|
|
||
| assert 'os.getenv("SESSION_SECRET_KEY", os.urandom' not in source | ||
| assert 'if os.getenv("ENV_VERSION") == "PROD"' in source |
|
|
||
| assert 'os.getenv("SESSION_SECRET_KEY", os.urandom' not in source | ||
| assert 'if os.getenv("ENV_VERSION") == "PROD"' in source | ||
| assert 'raise RuntimeError("SESSION_SECRET_KEY must be set in production.")' in source No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #201
Summary
SESSION_SECRET_KEYis present and at least 32 characters longapi/main.pyfrom falling back to a generated random session secret in productionValidation