Skip to content

Trivial tensors fast path into TensorOperations machinery #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lkdvos merged 2 commits into from
Jun 29, 2026
+15 −5
Merged

Trivial tensors fast path into TensorOperations machinery #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2aacf71
`has_array_view` for fast-path TensorOperations implementations
lkdvos Jun 25, 2026
bb80f9d
allocator for tensoradd
lkdvos Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/tensors/indexmanipulations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,8 +553,7 @@ Base.@deprecate(
if p[1] === codomainind(tsrc) && p[2] === domainind(tsrc)
add!(tdst, tsrc, α, β)
else
I = sectortype(tdst)
if I === Trivial
if has_array_view(tdst) && has_array_view(tsrc)
TO.tensoradd!(tdst[], tsrc[], p, false, α, β, backend, allocator)
else
ntasks = use_threaded_transform(tdst, transformer) ? get_num_transformer_threads() : 1
Expand Down
17 changes: 14 additions & 3 deletions src/tensors/tensoroperations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,13 @@ function _canonicalize(p::IndexTuple, t::AbstractTensorMap)
return (p₁, p₂)
end

# Whether a tensor can be viewed as a single contiguous array, such that
# the fusiontree machinery and act directly on the `t[]` view.
has_array_view(t) = has_array_view(typeof(t))
has_array_view(::Type) = false
has_array_view(::Type{T}) where {T <: TensorMap} = sectortype(T) === Trivial
has_array_view(::Type{T}) where {T <: AdjointTensorMap} = has_array_view(parenttype(T))

# tensoradd!
function TO.tensoradd!(
C::AbstractTensorMap,
Expand All @@ -43,9 +50,9 @@ function TO.tensoradd!(
if conjA
A′ = adjoint(A)
pA′ = adjointtensorindices(A, _canonicalize(pA, C))
permute!(C, A′, pA′, α, β, backend)
permute!(C, A′, pA′, α, β, backend, allocator)
else
permute!(C, A, _canonicalize(pA, C), α, β, backend)
permute!(C, A, _canonicalize(pA, C), α, β, backend, allocator)
end
return C
end
Expand Down Expand Up @@ -125,6 +132,10 @@ function TO.tensorcontract!(
)
pAB′ = _canonicalize(pAB, C)
@boundscheck spacecheck_contract(C, A, pA, conjA, B, pB, conjB, pAB′)
if has_array_view(C) && has_array_view(A) && has_array_view(B)
TO.tensorcontract!(C[], A[], pA, conjA, B[], pB, conjB, pAB′, α, β, backend, allocator)
return C
end
if conjA && conjB
A′ = A'
pA′ = adjointtensorindices(A, pA)
Expand Down Expand Up @@ -219,7 +230,7 @@ function trace_permute!(
q₁ = $(q₁), q₂ = $(q₂)"))
end

if I === Trivial
if has_array_view(tdst) && has_array_view(tsrc)
TO.tensortrace!(tdst[], tsrc[], (p₁, p₂), (q₁, q₂), false, α, β, backend)
else
_trace_permute!(FusionStyle(I), tdst, tsrc, (p₁, p₂), (q₁, q₂), α, β, backend)
Expand Down
Loading