Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the foundational connection layer used by future cluster communication components:
The focus of this PR is protocol compatibility and connection behavior rather than business logic migration.
Implemented
Connection framework
Xshard communication layer
Protocol support
Compatibility Validation
Verified against the Python implementation:
The compatibility tests use a real Python peer process and validate Go↔Python communication over TCP.
Testing
Two categories of tests are included:
Unit tests
Validate Go-side connection behavior:
Python compatibility tests
Validate interoperability with the Python implementation:
These compatibility tests establish the reusable test infrastructure that future cluster communication components (e.g. MasterConn and other cluster connection types) can build upon.
Out of Scope
This PR does not migrate cluster business logic.
The following are intentionally deferred to later PRs: