Skip to content

perf(ui): vertical split pane RepaintBoundary (#360) #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Jul 26, 2026
Merged

perf(ui): vertical split pane RepaintBoundary (#360) #370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/perf-baseline.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ Repeat on a **120 Hz** display (budget **≤ 8.3 ms** build+raster). Prefer prof
12. **Results modes**: idle → run (spinner) → grid; force an error — mode keys morph; scrolling the grid must not fade rows.
13. **Dialog / dropdown**: open/close `showAppDialog` and a `QueryaDropdown` — enter fade-slide, exit uses exit curve; Motion Off snaps.
14. **Theme cross-fade**: Preferences → enable Animate theme + Motion Full; switch dark/light — shadcn + `AnimatedQueryaTheme` lerp. Repeat with Motion Off (snap).
15. **Split settle**: drag the connections sidebar handle and the SQL/results vertical split with a fling — mid-drag stays 1:1; release may soft-settle. Focus the handle — ring uses motion tokens (not mid-drag animation).
15. **Split settle**: drag the connections sidebar handle and the SQL/results vertical split with a fling — mid-drag stays 1:1; release may soft-settle. Focus the handle — ring uses motion tokens (not mid-drag animation). Expect **layout** of editor/results each tick (constraint/flex); paint is isolated via `RepaintBoundary` on panes — do not add mid-drag springs to “fix” that cost.
10 changes: 8 additions & 2 deletions lib/core/layout/vertical_split_pane.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,10 @@ class _VerticalSplitPaneState extends State<VerticalSplitPane>
return Column(
crossAxisAlignment: CrossAxisAlignment.stretch,
children: [
Expanded(flex: topFlex, child: pair.top),
Expanded(
flex: topFlex,
child: material.RepaintBoundary(child: pair.top),
),
QueryaSplitHandle(
key: widget.handleKey,
axis: material.Axis.vertical,
Expand All @@ -136,7 +139,10 @@ class _VerticalSplitPaneState extends State<VerticalSplitPane>
);
},
),
Expanded(flex: bottomFlex, child: pair.bottom),
Expanded(
flex: bottomFlex,
child: material.RepaintBoundary(child: pair.bottom),
),
],
);
},
Expand Down
Loading