Skip to content

perf(ui): gate update badge pulse ticker (#363) - #373

Merged
ZhuchkaTriplesix merged 1 commit into
devfrom
issue/363-badge-pulse-lifecycle
Jul 26, 2026
Merged

perf(ui): gate update badge pulse ticker (#363)#373
ZhuchkaTriplesix merged 1 commit into
devfrom
issue/363-badge-pulse-lifecycle

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

  • Pulse only while badge visible and Motion not Off / OS disableAnimations
  • Named kUpdateBadgePulsePeriod constant
  • Widget tests for show/hide and motion off

Closes #363

Test plan

  • flutter test test/features/updater/update_available_badge_test.dart

Made with Cursor

Start AnimationController.repeat only while the badge is visible and
motion is enabled; document pulse period as kUpdateBadgePulsePeriod.

Closes #363

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added performance Theme parser epic label: performance motion Animation system, transitions, motion tokens ui User interface components and widgets labels Jul 26, 2026
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 835dd73 into dev Jul 26, 2026
2 of 3 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/363-badge-pulse-lifecycle branch July 26, 2026 20:36
ZhuchkaTriplesix added a commit that referenced this pull request Jul 27, 2026
@ZhuchkaTriplesix ZhuchkaTriplesix self-assigned this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

motion Animation system, transitions, motion tokens performance Theme parser epic label: performance ui User interface components and widgets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant