Skip to content

Perf: Offload heavy JSON decoding to Isolate #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Jul 29, 2026
Merged

Perf: Offload heavy JSON decoding to Isolate #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/core/market/http_marketplace_repository.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import 'dart:async';
import 'dart:convert';
import 'dart:io';
import 'dart:isolate';
import 'package:archive/archive.dart';
import 'package:flutter/foundation.dart';
import 'package:http/http.dart' as http;
Expand Down Expand Up @@ -72,7 +73,8 @@ class HttpMarketplaceRepository implements MarketplaceRepository {
if (response.statusCode != 200) {
throw MarketplaceException('Failed to load trending extensions (HTTP ${response.statusCode})');
}
final List<dynamic> data = jsonDecode(response.body) as List<dynamic>;
final body = response.body;
final List<dynamic> data = await Isolate.run(() => jsonDecode(body)) as List<dynamic>;
return data.map((json) => ExtensionManifest.fromJson(json as Map<String, dynamic>)).toList();
}

Expand All @@ -89,7 +91,8 @@ class HttpMarketplaceRepository implements MarketplaceRepository {
if (response.statusCode != 200) {
throw MarketplaceException('Search failed (HTTP ${response.statusCode})');
}
final List<dynamic> data = jsonDecode(response.body) as List<dynamic>;
final body = response.body;
final List<dynamic> data = await Isolate.run(() => jsonDecode(body)) as List<dynamic>;
return data.map((json) => ExtensionManifest.fromJson(json as Map<String, dynamic>)).toList();
}

Expand Down
7 changes: 5 additions & 2 deletions lib/core/updater/github_releases_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import 'dart:convert';
import 'dart:isolate';

import 'package:http/http.dart' as http;

Expand Down Expand Up @@ -28,7 +29,8 @@ class GitHubReleasesClient {
'GitHub Releases API returned HTTP ${response.statusCode}',
);
}
final decoded = jsonDecode(response.body);
final body = response.body;
final decoded = await Isolate.run(() => jsonDecode(body));
if (decoded is! Map<String, dynamic>) {
throw const GitHubReleasesException('Unexpected GitHub Releases payload');
}
Expand All @@ -41,7 +43,8 @@ class GitHubReleasesClient {
'GitHub Releases API returned HTTP ${response.statusCode}',
);
}
final decoded = jsonDecode(response.body);
final body = response.body;
final decoded = await Isolate.run(() => jsonDecode(body));
if (decoded is! List) {
throw const GitHubReleasesException('Unexpected GitHub Releases list payload');
}
Expand Down
Loading