Skip to content

Perf: Use cacheWidth/cacheHeight for image downsampling #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Jul 29, 2026
Merged

Perf: Use cacheWidth/cacheHeight for image downsampling #543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/features/connections/connections_panel_extension.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,8 @@ class _ExtensionConnectionTileState extends State<_ExtensionConnectionTile> {
widget.iconAsset!,
width: QueryaIconSizes.sidebarConnectionIcon,
height: QueryaIconSizes.sidebarConnectionIcon,
cacheWidth: (QueryaIconSizes.sidebarConnectionIcon * MediaQuery.devicePixelRatioOf(context)).toInt(),
cacheHeight: (QueryaIconSizes.sidebarConnectionIcon * MediaQuery.devicePixelRatioOf(context)).toInt(),
fit: material.BoxFit.contain,
errorBuilder: (_, __, ___) => material.Icon(
widget.icon,
Expand Down
2 changes: 2 additions & 0 deletions lib/features/connections/connections_panel_mongo.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,8 @@ class _MongoConnectionTileState extends State<_MongoConnectionTile> {
widget.iconAsset!,
width: QueryaIconSizes.sidebarConnectionIcon,
height: QueryaIconSizes.sidebarConnectionIcon,
cacheWidth: (QueryaIconSizes.sidebarConnectionIcon * MediaQuery.devicePixelRatioOf(context)).toInt(),
cacheHeight: (QueryaIconSizes.sidebarConnectionIcon * MediaQuery.devicePixelRatioOf(context)).toInt(),
fit: material.BoxFit.contain,
errorBuilder: (_, __, ___) => material.Icon(
widget.icon,
Expand Down
2 changes: 2 additions & 0 deletions lib/features/connections/connections_panel_mysql.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ class _MysqlConnectionTileState extends State<_MysqlConnectionTile> {
widget.iconAsset!,
width: QueryaIconSizes.sidebarConnectionIcon,
height: QueryaIconSizes.sidebarConnectionIcon,
cacheWidth: (QueryaIconSizes.sidebarConnectionIcon * MediaQuery.devicePixelRatioOf(context)).toInt(),
cacheHeight: (QueryaIconSizes.sidebarConnectionIcon * MediaQuery.devicePixelRatioOf(context)).toInt(),
fit: material.BoxFit.contain,
errorBuilder: (_, __, ___) => material.Icon(
widget.icon,
Expand Down
2 changes: 2 additions & 0 deletions lib/features/connections/connections_panel_postgres_connection.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ class _PostgresConnectionTileState extends State<_PostgresConnectionTile> {
widget.iconAsset!,
width: QueryaIconSizes.sidebarConnectionIcon,
height: QueryaIconSizes.sidebarConnectionIcon,
cacheWidth: (QueryaIconSizes.sidebarConnectionIcon * MediaQuery.devicePixelRatioOf(context)).toInt(),
cacheHeight: (QueryaIconSizes.sidebarConnectionIcon * MediaQuery.devicePixelRatioOf(context)).toInt(),
fit: material.BoxFit.contain,
errorBuilder: (_, __, ___) => material.Icon(
widget.icon,
Expand Down
2 changes: 2 additions & 0 deletions lib/features/connections/connections_panel_redis.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,8 @@ class _RedisConnectionTileState extends State<_RedisConnectionTile> {
widget.iconAsset!,
width: QueryaIconSizes.sidebarConnectionIcon,
height: QueryaIconSizes.sidebarConnectionIcon,
cacheWidth: (QueryaIconSizes.sidebarConnectionIcon * MediaQuery.devicePixelRatioOf(context)).toInt(),
cacheHeight: (QueryaIconSizes.sidebarConnectionIcon * MediaQuery.devicePixelRatioOf(context)).toInt(),
fit: material.BoxFit.contain,
errorBuilder: (_, __, ___) => material.Icon(
widget.icon,
Expand Down
2 changes: 2 additions & 0 deletions lib/features/connections/connections_panel_sidebar.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ class _ConnectionTile extends StatelessWidget {
iconAsset!,
width: QueryaIconSizes.sidebarConnectionIcon,
height: QueryaIconSizes.sidebarConnectionIcon,
cacheWidth: (QueryaIconSizes.sidebarConnectionIcon * MediaQuery.devicePixelRatioOf(context)).toInt(),
cacheHeight: (QueryaIconSizes.sidebarConnectionIcon * MediaQuery.devicePixelRatioOf(context)).toInt(),
fit: material.BoxFit.contain,
errorBuilder: (_, __, ___) => material.Icon(
icon,
Expand Down
2 changes: 2 additions & 0 deletions lib/features/connections/connections_panel_sqlite.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ class _SqliteConnectionTileState extends State<_SqliteConnectionTile> {
widget.iconAsset!,
width: QueryaIconSizes.sidebarConnectionIcon,
height: QueryaIconSizes.sidebarConnectionIcon,
cacheWidth: (QueryaIconSizes.sidebarConnectionIcon * MediaQuery.devicePixelRatioOf(context)).toInt(),
cacheHeight: (QueryaIconSizes.sidebarConnectionIcon * MediaQuery.devicePixelRatioOf(context)).toInt(),
fit: material.BoxFit.contain,
errorBuilder: (_, __, ___) => material.Icon(
widget.icon,
Expand Down
6 changes: 6 additions & 0 deletions lib/features/connections/driver_icon.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,13 @@ class DriverIcon extends StatelessWidget {
);
}
if (assetPath != null) {
final cacheSize = (size * MediaQuery.devicePixelRatioOf(context)).toInt();
return material.Image.asset(
assetPath!,
width: size,
height: size,
cacheWidth: cacheSize,
cacheHeight: cacheSize,
fit: material.BoxFit.contain,
filterQuality: material.FilterQuality.medium,
errorBuilder: (_, __, ___) => fallback,
Expand Down Expand Up @@ -83,10 +86,13 @@ class DriverIconImage extends StatelessWidget {
errorBuilder: (_, __, ___) => fallback,
);
}
final cacheSize = (size * MediaQuery.devicePixelRatioOf(context)).toInt();
return material.Image.file(
file,
width: size,
height: size,
cacheWidth: cacheSize,
cacheHeight: cacheSize,
fit: material.BoxFit.contain,
filterQuality: material.FilterQuality.medium,
errorBuilder: (_, __, ___) => fallback,
Expand Down
2 changes: 2 additions & 0 deletions lib/features/mysql/mysql_connection_form.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,8 @@ class _MysqlConnectionFormContentState
height: 24,
child: material.Image.asset(
'assets/images/mysql_icon.png',
cacheWidth: (40 * MediaQuery.devicePixelRatioOf(context)).toInt(),
cacheHeight: (40 * MediaQuery.devicePixelRatioOf(context)).toInt(),
fit: material.BoxFit.contain,
errorBuilder: (_, __, ___) => material.Icon(
material.Icons.table_chart_rounded,
Expand Down
4 changes: 3 additions & 1 deletion lib/features/mysql/mysql_stats_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ class _MysqlStatsViewState extends material.State<MysqlStatsView> {
);

final cs = Theme.of(context).colorScheme;
final width = material.MediaQuery.sizeOf(context).width;
final width = MediaQuery.sizeOf(context).width;

if (_loading) {
return material.Center(
Expand Down Expand Up @@ -254,6 +254,8 @@ class _MysqlStatsViewState extends material.State<MysqlStatsView> {
height: 28,
child: material.Image.asset(
'assets/images/mysql_icon.png',
cacheWidth: (28 * MediaQuery.devicePixelRatioOf(context)).toInt(),
cacheHeight: (28 * MediaQuery.devicePixelRatioOf(context)).toInt(),
fit: material.BoxFit.contain,
errorBuilder: (_, __, ___) => material.Icon(
material.Icons.storage_rounded,
Expand Down
2 changes: 2 additions & 0 deletions lib/features/postgresql/postgres_stats_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,8 @@ class _PostgresStatsViewState extends material.State<PostgresStatsView> {
height: 28,
child: material.Image.asset(
'assets/images/postgresql_icon.png',
cacheWidth: (32 * MediaQuery.devicePixelRatioOf(context)).toInt(),
cacheHeight: (32 * MediaQuery.devicePixelRatioOf(context)).toInt(),
fit: material.BoxFit.contain,
errorBuilder: (_, __, ___) => material.Icon(
material.Icons.storage_rounded,
Expand Down
2 changes: 2 additions & 0 deletions lib/features/postgresql/postgresql_connection_form.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,8 @@ class _PostgresConnectionFormContentState
height: 24,
child: material.Image.asset(
'assets/images/postgresql_icon.png',
cacheWidth: (40 * MediaQuery.devicePixelRatioOf(context)).toInt(),
cacheHeight: (40 * MediaQuery.devicePixelRatioOf(context)).toInt(),
fit: material.BoxFit.contain,
errorBuilder: (_, __, ___) => material.Icon(
material.Icons.storage_rounded,
Expand Down
Loading