fix(release): stamp versions after lint/test to avoid biome formatting failure#19
Merged
Conversation
npm pkg set version reformats package.json (expanding single-line arrays/objects), which biome's formatter rejects — so stamping before the Lint step failed the release for every package. Move the version stamp to immediately before publish so lint/test run on the pristine, biome-clean tree. Nothing embeds its own package.json version at build time, so building before the stamp is safe. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release run for
v3.0.0-beta.1failed at Lint: theSet package versions from tagstep runsnpm pkg set version, which rewrites everypackage.jsonand expands single-line arrays/objects (e.g."files": ["dist"]) to multiline — which biome's formatter rejects. Lint ran after the stamp, so it failed for every package before publish.Fix: reorder so the version stamp happens immediately before publish; lint/test/e2e run on the pristine, biome-clean tree. Verified locally:
pnpm build && pnpm lint && pnpm testall pass. Nothing embeds its own package.json version at build time, so building before the stamp is safe.🤖 Generated with Claude Code