452#461
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #452
#[app_error(...)]-generatedFromconversions now attach the domain error as source instead of discarding it, andAppErrorforwards providers.Codegen
message: message computed from the value, then the value moves into the source slot; withoutmessage: bare error + sourcematch &value, single.with_source(value)after the matchSelf: Error + Send + Sync + 'static(satisfied by the same derive; escape hatch below)no_sourceflag restores the old drop-value behavior for non-Send/Sync domain types (all-or-nothing across enum variants, mixed use is a compile error)Runtime
impl Error for AppErrorgains cfg-gatedprovide: forwards the attached backtrace and delegates to the stored source —request_ref/request_valuenow reach#[provide]data through a convertedAppErroron toolchains witherror_generic_member_accessis/downcast_ref/downcast/chain/root_causework through conversionsTests & docs
7-test integration file (incl. chain traversal to root cause and a ProblemJson regression: source never serialized), provide-forwarding tests, updated trybuild pass cases + new
no_sourcepass case withRcfields, 10 new derive unit tests (expansion + parser). README conversion paragraph rewritten (was: 'the domain error is dropped'), derive docs, wiki pages in three languages updated. Full workspace suite, doctests (176), no_std build, clippy zero warnings (all targets), nightly fmt, readme_sync, benches — all green after rebase over #447/#445.