[GRDM-61282] Update CS-repo2docker to 2026.07.2 and fix figshare DOI handling#29
Draft
yacchin1205 wants to merge 2 commits into
Draft
[GRDM-61282] Update CS-repo2docker to 2026.07.2 and fix figshare DOI handling#29yacchin1205 wants to merge 2 commits into
yacchin1205 wants to merge 2 commits into
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 77.59% 78.32% +0.72%
==========================================
Files 44 28 -16
Lines 3616 3336 -280
Branches 47 0 -47
==========================================
- Hits 2806 2613 -193
+ Misses 785 723 -62
+ Partials 25 0 -25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
yacchin1205
force-pushed
the
feature/repo2docker-2026.07.2
branch
from
4634ca5 to
9c40da1
Compare
rather than parse mutable URL schemes (since it has changed recently), parse more stable doi scheme and use figshare API to resolve versions if needed important fix: for dois without version, figshare resolves to latest, not 1
yacchin1205
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CS-repo2dockerの参照を 2026.07.2 に更新します。
CS-binderhub 単体の動作には現行の参照のままでも問題はありませんが、CS-tljh-repo2docker の CI は「CS-binderhub と CS-repo2docker を同一環境に pip インストールし、binderhub ビルドバックエンド経由で Python パッケージ版の repo2docker が解析環境をビルドする」構成を検証しており、この使用場面では解析環境のビルドが失敗する問題への対処(RCOSDP/CS-repo2docker#30)を含む 2026.07.2 が必要です。
あわせて、figshare が新しい URL 形式を返す環境で DOI からのサービス起動・ビルドができない問題(GRDM-61282)への対応として、upstream の修正 jupyterhub/binderhub@6456ae7 を cherry-pick で取り込みます。CI の tests (v1.30, main) で失敗していた figshare provider テストはこの問題によるものです。