Skip to content

PolkadotSDK stable2606#2837

Closed
UnArbosSix wants to merge 15 commits into
mainfrom
upgrade-polkadot-v1.24.0
Closed

PolkadotSDK stable2606#2837
UnArbosSix wants to merge 15 commits into
mainfrom
upgrade-polkadot-v1.24.0

Conversation

@UnArbosSix

@UnArbosSix UnArbosSix commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Description

Upgrades Subtensor from the previous Polkadot SDK pin to the RaoFoundation stable2606 SDK revision, along with the matching Frontier fork revision and Rust 1.93.0 toolchain pin required by that SDK line.

What Changed

  • Updated workspace Polkadot SDK, Frontier, and related dependency pins in Cargo.toml and refreshed Cargo.lock.
  • Adapted runtime and node code for stable2606 API changes, including authorized transaction creation for drand offchain submissions, updated transaction extension ordering, session key generation API changes, lazy block runtime API signatures, and block length construction.
  • Updated affected pallets, precompiles, support procedural code, scripts, Dockerfile, and Rust setup docs for the new SDK/toolchain surface.
  • Bumped runtime/src/lib.rs spec_version from 424 to 425.

Behavioral Impact

This is a runtime-affecting dependency upgrade. The drand offchain worker now submits authorized transactions through the stable2606 transaction-extension path instead of the removed bare unsigned transaction path. Transaction extension construction and metadata hash handling are updated to match the new SDK APIs.

Migration / Spec Version

No storage migration is introduced by this PR. The runtime spec_version is bumped to 425 for the SDK/runtime changes.

Testing

The original PR body did not document testing performed. CI should at minimum cover workspace build/checks, runtime compilation, drand pallet tests, precompile tests, and eco-tests after dependency pins are made consistent.

@UnArbosSix UnArbosSix added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

eco-tests changed — indexer review required

This PR modifies files under eco-tests/. and may affect downstream indexing.
cc @evgeny-s — please review manually

Changed files
  • eco-tests/Cargo.toml
  • eco-tests/src/mock.rs

@github-actions
github-actions Bot requested a review from evgeny-s July 7, 2026 21:46
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

VERY HIGH account-age/activity scrutiny, moderated by repository write permission; no Gittensor association or author/committer mismatch; upgrade-polkadot-v1.24.0 → main.

Static analysis covered the full SDK/Frontier dependency repin, runtime transaction-extension changes, drand authorization path, shielded extrinsic decoding, vendored cryptographic and execution code, runtime API adaptations, and build/workflow edits. Protected AI-review instructions were not modified, the runtime spec version was bumped, and git dependencies are revision-pinned.

Findings

No findings.

Conclusion

No malicious intent or actionable PR-introduced security vulnerability was found.


🔍 AI Review — Auditor (domain review)

VERDICT: 👍

Gittensor UNKNOWN; the author has a very new public profile but repository write permission, so dependency, runtime, drand, and vendored cryptography changes received heightened scrutiny.

The stable2606 SDK adaptation, Frontier/BLS vendor updates, authorized drand transaction path, and dependency pins are coherent. Overlapping open PRs concern unrelated features or fixes rather than duplicating this SDK upgrade.

The PR description has one stale detail: it says spec_version changed from 424 to 425, while the current diff changes it from 432 to 433.

git diff --check passed; no auto-fixes were needed. No builds or tests were run because no finding required runtime confirmation.

Findings

No findings.

Conclusion

No substantive correctness or domain-rule violations were found. The PR is ready aside from correcting the stale spec-version values in its description.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: VULNERABLE

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

Comment thread eco-tests/Cargo.toml Outdated
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👎

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

Comment thread eco-tests/Cargo.toml Outdated
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👎

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

Comment thread Cargo.toml Outdated
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: VULNERABLE

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

1 similar comment
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

Comment thread pallets/subtensor/src/utils/evm.rs Outdated
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: VULNERABLE

@UnArbosSix
UnArbosSix force-pushed the upgrade-polkadot-v1.24.0 branch from 37711f2 to e014eeb Compare July 8, 2026 16:33
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

1 similar comment
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@vercel

vercel Bot commented Jul 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
subtensor Ready Ready Preview, Comment Jul 17, 2026 5:27pm

Request Review

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@UnArbosSix UnArbosSix added skip-cargo-audit This PR fails cargo audit but needs to be merged anyway and removed skip-cargo-audit This PR fails cargo audit but needs to be merged anyway labels Jul 9, 2026
@UnArbosSix
UnArbosSix force-pushed the upgrade-polkadot-v1.24.0 branch from f2e5bbe to eb60f1b Compare July 17, 2026 16:26
@UnArbosSix
UnArbosSix changed the base branch from devnet-ready to main July 17, 2026 16:26
@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant