PolkadotSDK stable2606#2837
Conversation
eco-tests changed — indexer review requiredThis PR modifies files under Changed files
|
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE VERY HIGH account-age/activity scrutiny, moderated by repository write permission; no Gittensor association or author/committer mismatch; upgrade-polkadot-v1.24.0 → main. Static analysis covered the full SDK/Frontier dependency repin, runtime transaction-extension changes, drand authorization path, shielded extrinsic decoding, vendored cryptographic and execution code, runtime API adaptations, and build/workflow edits. Protected AI-review instructions were not modified, the runtime spec version was bumped, and git dependencies are revision-pinned. FindingsNo findings. ConclusionNo malicious intent or actionable PR-introduced security vulnerability was found. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 Gittensor UNKNOWN; the author has a very new public profile but repository write permission, so dependency, runtime, drand, and vendored cryptography changes received heightened scrutiny. The stable2606 SDK adaptation, Frontier/BLS vendor updates, authorized drand transaction path, and dependency pins are coherent. Overlapping open PRs concern unrelated features or fixes rather than duplicating this SDK upgrade. The PR description has one stale detail: it says
FindingsNo findings. ConclusionNo substantive correctness or domain-rule violations were found. The PR is ready aside from correcting the stale spec-version values in its description. |
|
🔄 AI review updated — Skeptic: VULNERABLE |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👎 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👎 |
|
🔄 AI review updated — Skeptic: VULNERABLE |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
1 similar comment
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: VULNERABLE |
37711f2 to
e014eeb
Compare
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
1 similar comment
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
f2e5bbe to
eb60f1b
Compare
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Description
Upgrades Subtensor from the previous Polkadot SDK pin to the RaoFoundation stable2606 SDK revision, along with the matching Frontier fork revision and Rust 1.93.0 toolchain pin required by that SDK line.
What Changed
Cargo.tomland refreshedCargo.lock.runtime/src/lib.rsspec_versionfrom 424 to 425.Behavioral Impact
This is a runtime-affecting dependency upgrade. The drand offchain worker now submits authorized transactions through the stable2606 transaction-extension path instead of the removed bare unsigned transaction path. Transaction extension construction and metadata hash handling are updated to match the new SDK APIs.
Migration / Spec Version
No storage migration is introduced by this PR. The runtime
spec_versionis bumped to 425 for the SDK/runtime changes.Testing
The original PR body did not document testing performed. CI should at minimum cover workspace build/checks, runtime compilation, drand pallet tests, precompile tests, and eco-tests after dependency pins are made consistent.