fix(scheduler): throw RangeError for delays beyond setInterval maximum#7609
Open
niklas-wortmann wants to merge 5 commits into
Open
fix(scheduler): throw RangeError for delays beyond setInterval maximum#7609niklas-wortmann wants to merge 5 commits into
niklas-wortmann wants to merge 5 commits into
Conversation
…ding Encode repo conventions via rules, skills, hooks, and Bugbot review gates. Add operator scaffolding, QA repro-to-test workflow, local release path, Firebase docs preview config, and repo-bundled Yarn for reproducible setup. Add bug-fix and GitHub-issue skills; document scheduler/timer test pitfalls. Co-authored-by: Cursor <cursoragent@cursor.com>
…eases Rename rxjs-verdaccio-publish to rxjs-publish, add non-interactive auth and background Verdaccio setup to the skill, and add an --interactive flag to release.js so unattended runs skip the changelog editor prompt. Co-authored-by: Cursor <cursoragent@cursor.com>
Document NX_DAEMON=false for sandboxed shells, gh CLI token handling without printing credentials, git-tag-based version inference, and running the dry run with --interactive=false, all learned from a real Verdaccio release run. Co-authored-by: Cursor <cursoragent@cursor.com>
JavaScript timers clamp delays above 2^31-1 ms and may fire immediately, causing timer() and delay() with far-future dates to emit right away. Validate delay in AsyncAction.requestAsyncId and throw RangeError instead. Fixes ReactiveX#7602 Co-authored-by: Cursor <cursoragent@cursor.com>
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx compile rxjs |
❌ Failed | 16s | View ↗ |
💡 Dealing with memory or CPU issues? See memory and CPU details with the resource usage add-on ↗.
☁️ Nx Cloud last updated this comment at 2026-07-06 18:46:05 UTC
dynst
reviewed
Jul 10, 2026
Comment on lines
+1
to
+11
| # 7.0.0 (2026-07-05) | ||
|
|
||
| ### 🚀 Features | ||
|
|
||
| - Add es2015 entries to the exports declaration to support Angular | ||
|
|
||
| - ⚠️ RxJS updated to TypeScript 4.9 | ||
|
|
||
| - ⚠️ Dropping support for Node 14. | ||
|
|
||
| - No longer publishing UMD or ES5 builds |
There was a problem hiding this comment.
This doesn't seem related to the bug fix. There are 5 commits in the branch but only the latest commit fixes the bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RangeErrorwhenasyncScheduleris asked to schedule a delay longer than2^31 - 1ms (~24.8 days), instead of silently firing immediately due to platform timer clamping.AsyncAction.requestAsyncIdso virtual schedulers (TestScheduler) are unaffected.timeranddelaywith numeric andDatedelays usingasyncScheduler.Fixes #7602
Test plan
yarn workspace rxjs test -- --grep 'platform max'yarn workspace rxjs test -- --grep '^(delay|timer)'yarn workspace rxjs lintMade with Cursor