Fix wrong conditional checks for Twitter/GitHub links in featured cards#401
Open
arijitroy003 wants to merge 1 commit into
Open
Fix wrong conditional checks for Twitter/GitHub links in featured cards#401arijitroy003 wants to merge 1 commit into
arijitroy003 wants to merge 1 commit into
Conversation
…eatured cards The Twitter and GitHub link blocks in the featured project cards both checked `feature.website` instead of `feature.twitter` and `feature.github` respectively. This caused those links to render whenever a website was set, even if no Twitter/GitHub URL existed, and to be hidden when only Twitter/GitHub was set without a website. Fixes RedHatOfficial#396
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The featured project cards in
templates/index.htmlhad incorrect conditional checks for the Twitter and GitHub link blocks. Both blocks checkedfeature.websiteinstead of their respective variables:{% if feature.website %}guarded the Twitter link — changed to{% if feature.twitter %}{% if feature.website %}guarded the GitHub link — changed to{% if feature.github %}This caused two problems:
href) whenever a website URL existed, even if no Twitter/GitHub URL was setVerification
feature.websiteon the affected lines{% if %}conditional now matches its corresponding<a href>target{% if feature.website or feature.github or feature.twitter %}guard on line 37 remains correctFixes #396