build(cmake): add options to build the GXS Wiki and The Wire services#317
Open
jolavillette wants to merge 1 commit into
Open
build(cmake): add options to build the GXS Wiki and The Wire services#317jolavillette wants to merge 1 commit into
jolavillette wants to merge 1 commit into
Conversation
jolavillette
force-pushed
the
feature/cmake-enable-wire-wiki
branch
3 times, most recently
from
July 7, 2026 22:02
55a616f to
3a985c4
Compare
csoler
reviewed
Jul 8, 2026
| #./rsitems/rswikiitems.cc | ||
| #./rsitems/rswikiitems.h | ||
| #./rsitems/rswireitems.h | ||
| # NOTE: rswikiitems / rswireitems sources are added further below in the |
Contributor
There was a problem hiding this comment.
plz remove this comment. It's not needed anymore since the removed elements are...removed!
jolavillette
force-pushed
the
feature/cmake-enable-wire-wiki
branch
from
July 8, 2026 20:10
3a985c4 to
5deb4d4
Compare
jolavillette
force-pushed
the
feature/cmake-enable-wire-wiki
branch
from
July 18, 2026 13:33
5deb4d4 to
9e712a8
Compare
The CMake build never compiled the experimental GXS "Wiki" (WikiPoos) and "The Wire" services: their sources were commented out in src/CMakeLists.txt and no option defined the RS_USE_WIKI / RS_USE_WIRE macros that gate the service instantiation in rsserver/rsinit.cc and the matching GUI code. As a result the retroshare-gui RS_GXSWIKIPOS / RS_GXSTHEWIRE blocks could not be enabled to a working build. Mirror the qmake "wikipoos" / "gxsthewire" CONFIG switches: - Add RS_GXSWIKIPOS and RS_GXSTHEWIRE options (default OFF, as in qmake). - Compile the p3wiki/p3wire services, rswikiitems/rswireitems and the rswiki.h/rswire.h public headers when the respective option is enabled. - Define RS_USE_WIKI / RS_USE_WIRE PUBLIC so libretroshare consumers see the same guard. Both features stay OFF by default; they are unmaintained and experimental. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jolavillette
force-pushed
the
feature/cmake-enable-wire-wiki
branch
from
July 18, 2026 19:01
9e712a8 to
291c22c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CMake build never compiled the experimental GXS "Wiki" (WikiPoos) and "The Wire" services: their sources were commented out in src/CMakeLists.txt and no option defined the RS_USE_WIKI / RS_USE_WIRE macros that gate the service instantiation in rsserver/rsinit.cc and the matching GUI code. As a result the retroshare-gui RS_GXSWIKIPOS / RS_GXSTHEWIRE blocks could not be enabled to a working build.
Mirror the qmake "wikipoos" / "gxsthewire" CONFIG switches:
Both features stay OFF by default; they are unmaintained and experimental.