Skip to content

fix: detach analysis unable to find bookmark #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vgoat21 merged 1 commit into from
Jul 6, 2026
Merged

fix: detach analysis unable to find bookmark #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/ai/reveng/toolkit/ghidra/core/services/api/GhidraRevengService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,10 @@ public void removeProgramAssociation(Program program){
program.getUsrPropertyManager().removePropertyMap(REAI_FUNCTION_PROP_MAP);
program.getUsrPropertyManager().removePropertyMap(REAI_FUNCTION_MANGLED_MAP);

program.getBookmarkManager().removeBookmarks(REVENG_BOOKMARK_TYPE);
var bookmarkManager = program.getBookmarkManager();
if (bookmarkManager.getBookmarkType(REVENG_BOOKMARK_TYPE) != null) {
bookmarkManager.removeBookmarks(REVENG_BOOKMARK_TYPE);
}
var revengTag = program.getFunctionManager().getFunctionTagManager().getFunctionTag(REVENGAI_FUNCTION_TAG);
if (revengTag != null) {
revengTag.delete();
Expand Down
17 changes: 17 additions & 0 deletions src/test/java/ai/reveng/DetachProgramAssociationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
package ai.reveng;

import ai.reveng.toolkit.ghidra.core.services.api.mocks.UnimplementedAPI;
import ghidra.program.database.ProgramBuilder;
import org.junit.Test;

public class DetachProgramAssociationTest extends RevEngMockableHeadedIntegrationTest {

@Test
public void testDetachWithoutMarkedFunctions() throws Exception {
var service = addMockedService(env.getTool(), new UnimplementedAPI());
var builder = new ProgramBuilder("detach-test", ProgramBuilder._X64, this);
var program = builder.getProgram();

program.withTransaction("Undo binary association", () -> service.removeProgramAssociation(program));
}
}
Loading