Feat/fx cost aware selection new - #631
Merged
thlpkee20-wq merged 3 commits intoJul 29, 2026
Merged
Conversation
- Add FxProviderBudgetRegistry: tracks per-tenant monthly spend per
provider using a pluggable SpendStore interface; enforces monthlyCapUsd
caps with configurable degradationThreshold (default 90 %).
- Add CostAwareRateSelector: ranks providers by accuracyRank (desc),
skips exhausted providers, degrades to cheaper alternatives when near
budget limit, records spend on every API call, and emits:
* fx.provider.spend_month gauge (spend in USD this month)
* fx.provider.degraded_total counter (budget-pressure degradations)
* fx.provider.selection_total counter (all selections)
- Add InMemorySpendStore: single-process store for dev/test; production
deployments should wire a Postgres-backed implementation.
- Add docs/fx-cost-aware-selection.md covering architecture, config,
security assumptions, abuse/failure paths, and Postgres schema example.
- Add src/services/fxCostAwareSelection.test.ts with comprehensive
test suite (>= 95 % coverage target) covering:
* Budget registry CRUD and cap enforcement
* Normal provider selection (most accurate first)
* Near-limit and exhaustion degradation
* Budget cap exhaustion never blocks distributions
* Provider error / null rate handling
* Metric emission for gauge and counters
* Multi-tenant isolation
* Security edge cases (negative spend, storage failures, tenant
injection, fail-open behaviour)
|
@edochieblessing09-max Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #551
PR Description: