feat: GL-account filter for ledger export - #635
Merged
thlpkee20-wq merged 6 commits intoJul 29, 2026
Conversation
|
@sunnykid-02 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
Done. Close: #635 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #482
Summary
Implemented GET /api/v1/ledger/export?gl_account=&cursor=&limit= with HMAC-signed opaque cursor pagination and computed totals row.
Files changed
File Action Purpose
src/lib/pagination.ts Modified Added signCursor() / verifyCursor() HMAC-SHA256 helpers
src/services/ledgerExportService.ts Created LedgerExportService.byGlAccount(), InMemoryLedgerRepository, types, computeTotals() with BigInt arithmetic
src/routes/ledgerExport.ts Created Route handler with input validation
src/routes/ledgerExport.test.ts Created 10 contract tests covering all edge cases
src/db/repositories/ledgerEntryRepository.ts Created PG-backed PgLedgerEntryRepository for production use
src/index.ts Modified Mounted /ledger/export at apiRouter level
src/config/env.ts Modified Added CURSOR_SIGNING_SECRET and WEBHOOK_QUEUE_MAX_DEPTH
docs/ledger-export-gl-filter.md Created Full documentation
Key design decisions
Test results
Tests: 10 passed, 10 total
Coverage on new files: ledgerExport.ts 95.45%, ledgerExportService.ts 100% lines.