adding mocro in dbt project that enable re-useablity feature and prov…#33
Conversation
Ritik574-coder
left a comment
Ritik574-coder
left a comment
There was a problem hiding this comment.
adding micro and generic test
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ed2fbe601
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| AND TRY_CONVERT(INT, LEFT(TRIM({{ column_name }}), 2)) > 12 | ||
| THEN TRY_CONVERT(DATE, TRIM({{ column_name }}), 103) | ||
|
|
||
| ELSE TRY_CONVERT(DATE, TRIM({{ column_name }}), 101) |
There was a problem hiding this comment.
When date_of_birth is in the existing dd-mm-yyyy/mm-dd-yyyy format, this macro now falls through to style 101; for values already present in scripts/raw_dataset/csv_data_file/raw_customers.csv such as 29-01-1982, SQL Server interprets the first component as the month and TRY_CONVERT returns NULL. The replaced inline CASE had explicit __-__-____ branches with styles 105/110, so this change silently drops those DOBs and then trips the existing not_null test. Restore the hyphenated branches before the fallback.
Useful? React with 👍 / 👎.
1 participant
No description provided.