chore(build): re-run OS package upgrades on every image build#218
Merged
Conversation
The runner stage's apk upgrade layer was served from the GHA build cache, so security patches only landed when the base image digest moved. A per-build CACHE_DATE arg now busts that layer daily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensures OS-level security patches actually land in every image build. The runner stage runs
apk upgrade --no-cache, but with GHA layer caching (--cache-from type=gha) that layer is reused from cache and never re-executes — upgrades only landed when the base image digest happened to move. This is why the image scanner kept reporting OS package findings that a fresh build would have cleared.Changes
Dockerfile
ARG CACHE_DATEconsumed at the start of the runner stage'sapk upgradelayer, so a changed value invalidates the layer (and everything after it, including thenpm install -g npm@latestrefresh)..github/workflows/build.yml
--build-arg CACHE_DATE=$(date -u +%Y%m%d)to the buildx invocation — the layer re-runs on the first build of each UTC day; same-day rebuilds keep full cache benefit.Testing