chore(reports): drop the report-package chart cast; client ^0.5.6#222
Merged
Conversation
Client 0.5.6 adds view.chart + row itemType to the report-package query, so getReportPackage's block type now matches the chart-aware BlockView envelope. Removes the bridging cast (and its now-unused EnvelopeBlock import) in the filed-report viewer. The earlier cast was never a @robosystems/core issue — core references the client live; it was the report-package query missing the chart selection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Client 0.5.6 (typescript-client #153) added
view.chart+ rowitemTypeto the report-package GraphQL query, sogetReportPackage().items[].blocknow carries the chart arm and matches the chart-awareBlockViewenvelope. This removes the temporary bridging cast (and its now-unusedEnvelopeBlockimport) from the filed-report viewer, and bumps the client range to^0.5.6.The cast was never a
@robosystems/coreproblem — core references the client's types live (one deduped client in the tree). It was purely the report-package query missing the chart selection; #153 fixed that at the source.Verification
Typecheck passes without the cast on client 0.5.6 (it failed without it on 0.5.5 — the query gap is genuinely closed); full
test:allgreen (174 tests), lockfile pinned to 0.5.6.