fix(aggregators): report original keyframe buffer size in VLM diff summary#800
Open
Bartok9 wants to merge 1 commit into
Open
fix(aggregators): report original keyframe buffer size in VLM diff summary#800Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
…mmary Keep original image-buffer length before first/middle/last selection so status text does not claim keyframes were selected from the post-downsample count. Fix docstring typo midden→middle. Add unit coverage for get_key_elements and the five-image case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
ROS2ImgVLMDiffAggregator.get()reported keyframes as selected fromlen(selected)twice, so when the buffer had more than 3 images the status text wrongly claimed e.g. "3 keyframes selected from 3 last images".Proposed Changes
get_key_elementsand the five-image summary string.Testing
tests/aggregators/test_ros2_logs_aggregator.py(ROS env / existing aggregator fixture conventions).specs/rai/2026-07-14-1.md(Composer 2.5 Standard posture; Grok-spec + review micro-diff).Duplicate check
No open PR for this summary-string fix.