fix(aggregators): flush trailing log-run repeat counts#802
Open
Bartok9 wants to merge 1 commit into
Open
Conversation
ROS2LogsAggregator previously only emitted \"Log above repeated N times\" when a different log interrupted the run, and that frame overwrote the new unique line. Flush complete runs correctly, including end-of-buffer duplicates, and keep every unique line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
ROS2LogsAggregator.get()lost unique lines when flushing a prior duplicate run, and never reported end-of-buffer consecutive duplicates.Proposed Changes
Log above repeated {k-1} timeswhenk > 1.Testing
tests/aggregators/test_ros2_logs_aggregator.pyupdated assertions.specs/rai/2026-07-15-1.md(aerial dual-agent; Grok-spec + Bartok review micro-diff when Cursor cloud not mid-wired).Duplicate check
No open PR for logs-aggregator trailing-run flush.