fix(tools): reject non-positive WaitForSecondsTool delays#803
Open
Bartok9 wants to merge 1 commit into
Open
Conversation
Keep the 10s upper cap, but refuse zero/negative/bool waits so agents cannot pass through invalid durations into time.sleep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
WaitForSecondsToolcapped upper waits at 10s but still accepted non-positive values (and bools, sinceboolsubclassesint), which agents could pass through totime.sleep.Proposed Changes
int/boolandseconds <= 0withValueError.Testing
tests/tools/test_wait_for_seconds_tool.py(sleep mocked).specs/rai/2026-07-15-2.md(aerial dual-agent; Grok-spec + Bartok review micro-diff).Duplicate check
No open PR for WaitForSecondsTool non-positive validation.