Rohan/zed streaming#5
Conversation
nhat-m-le
left a comment
nhat-m-le
left a comment
There was a problem hiding this comment.
Left a few comments and requests
|
|
||
| 1. SSH into the robot as `nvidia`. | ||
| 2. Run `./scripts/zed_rtsp/start_zed_rtsp_stack.sh`. | ||
| 3. Tell viewers to open `rtsp://192.168.0.159:8554/zed`. |
There was a problem hiding this comment.
use <robot_ip> placeholder instead of a specific value
| LAN viewer: | ||
|
|
||
| ```bash | ||
| ./scripts/zed_rtsp/view_zed_rtsp_lan.sh 192.168.0.159 | ||
| ``` | ||
|
|
||
| SSH tunnel viewer: | ||
|
|
||
| ```bash | ||
| ./scripts/zed_rtsp/view_zed_rtsp_ssh_tunnel.sh nvidia@192.168.0.159 | ||
| ``` |
| ros2 launch image2rtsp image2rtsp.launch.py | ||
| ``` | ||
|
|
||
| ## View on the Lab LAN |
There was a problem hiding this comment.
Change the section name to something like wireless lan
There was a problem hiding this comment.
should use the repo-wide .gitignore
There was a problem hiding this comment.
should use the repo-wide .gitignore
There was a problem hiding this comment.
should use the repo-wide .gitignore
There was a problem hiding this comment.
it seems like you install and use image2rtsp from a different workspace. I'd prefer you to add this fork to ScoutMini/ros2_ws/src as a submodule and change code/documentation as needed. If you change any of image2rtsp code also make a PR to that fork.
Also, for the .sh scripts, I think they are great for testing the camera independently and we should keep them. Considering the structure of this repo, I'd prefer to have scoutmini_streaming as a ROS 2 package in ros2_ws/src and store most of the scripts currently in ScoutMini/scripts/zed_rtsp in the new package's test folder.
Furthermore, the camera is usually launched with the robot bringup launch file in our main workflow, so add to the new package's launch folder any image2rtsp launch you need to use and to the scripts folder new scripts that start and stop the stream assuming the camera and and image2rtsp are separately launched with ROS. Any config file should be located in this package too.
There was a problem hiding this comment.
remove this file and put in the PR instead
2 participants
Summary
Adds helper scripts and documentation for bringing up remote ZED camera
streaming from the ScoutMini robot.
This includes RTSP and WebRTC MediaMTX workflows, local install/start/stop/
check scripts, diagnostic collection helpers, bag recording helpers, viewer
scripts, and a simple WebRTC browser viewer.
Scope
docs/zed_rtsp_streaming.mdscripts/zed_rtsp/helper scripts, configs, ignore files, and viewerassets