CI-001B4C: retire stale hook lint directives#450
Merged
Conversation
✅ Deploy Preview for luminous-fox-7c393f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
daliu
commented
Jul 22, 2026
daliu
left a comment
Contributor
Author
There was a problem hiding this comment.
Self-review complete on exact head 9becaadc91b75790bdc00dda1fbd9976ae448394 against base 35240fa84efcda935b88eacbb0685e32aeb8ef10.
- The hosted PR contains exactly the ten issue-owned paths and one commit.
- Each TSX file changes only the specified comment line; executable output, effect bodies, dependency arrays, and line counts are unchanged.
- The normalized ledger delta is exactly four removed records and zero added, moved, or changed records; the committed ledger byte-matches a fresh generation.
- Three independent adversarial reviews covered source semantics, ledger integrity, test mutation resistance, documentation history, officer impact, and scope. Two wording/history findings were fixed and re-reviewed clean.
- All required local Node 20 / Java 17 gates pass. No unresolved review issue remains.
This review proves source and local test state only. The Netlify result is a pull-request preview, not production publication; Firebase, providers, production data, and live behavior are unchanged and unverified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the four remaining stale React hook lint directives without changing runtime behavior, and reduces the reviewed frontend lint ledger from 117 to 113 errors.
Officer impact: None. The four source changes are non-executable comments, and the rest of this pull request updates the reviewed lint ledger and engineering records only.
Officer documentation: None — no public, member, officer, admin, data, permission, account, provider, hosting, deployment, backup, or recovery behavior changes.
Deployment evidence: Local source and test evidence only. This pull request does not publish the website, deploy Firebase, configure a provider, inspect production, or prove live behavior.
Outcome
eslint-disable-next-line react-hooks/exhaustive-depsdirectives with ordinary comments on the same physical lines.sha256:80b91bb22c70f5f0d400703f8d79cda64c7b42ba3e2a33c91f67435d7a8adf52.RED and ledger evidence
sha256:56b52a74434e910548d72c741ab21b634274d3cc9c36fe9983d8942b34eebddf.frontend_lint_gate_failed:lint_rejected.react-hooks/exhaustive-depsunknown-rule records, zero additions, and no moved or changed records..github/lint-baseline.json.Verification
src/App.test.jsx: 310/310 passed.git diff --checkpassed.Review
Three independent adversarial reviews covered source semantics, exact-ledger integrity, documentation history, officer impact, and scope. Review found and corrected the same-UID user-projection wording in two comments and the 102→108→111 file-count chronology. All re-reviews are clean; no unresolved findings remain.
Closes #449