Skip to content

CI-001B4C: retire stale hook lint directives#450

Merged
daliu merged 1 commit into
mainfrom
codex/issue-449-stale-hook-directives
Jul 22, 2026
Merged

CI-001B4C: retire stale hook lint directives#450
daliu merged 1 commit into
mainfrom
codex/issue-449-stale-hook-directives

Conversation

@daliu

@daliu daliu commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

This removes the four remaining stale React hook lint directives without changing runtime behavior, and reduces the reviewed frontend lint ledger from 117 to 113 errors.

Officer impact: None. The four source changes are non-executable comments, and the rest of this pull request updates the reviewed lint ledger and engineering records only.

Officer documentation: None — no public, member, officer, admin, data, permission, account, provider, hosting, deployment, backup, or recovery behavior changes.

Deployment evidence: Local source and test evidence only. This pull request does not publish the website, deploy Firebase, configure a provider, inspect production, or prove live behavior.

Outcome

  • Replaces exactly four stale eslint-disable-next-line react-hooks/exhaustive-deps directives with ordinary comments on the same physical lines.
  • Preserves every executable statement, effect body, dependency array, and source line count.
  • Updates the exact-record baseline to 111 files, 113 configured errors, 6 warnings, 83 TSX errors, and fingerprint sha256:80b91bb22c70f5f0d400703f8d79cda64c7b42ba3e2a33c91f67435d7a8adf52.
  • Reconciles the authoritative CI/RISK-035 history with the reviewed file-count and error changes from PRs WEB-UX: polish shared page hero semantics #391 and PAY-001C1B: validate merchandise checkout request and options (#389) #392.

RED and ledger evidence

  • Before source changes, the checker passed at 111 files / 117 errors / 6 warnings with fingerprint sha256:56b52a74434e910548d72c741ab21b634274d3cc9c36fe9983d8942b34eebddf.
  • With only the four comment substitutions and the old ledger retained, the checker failed closed with frontend_lint_gate_failed:lint_rejected.
  • An independent normalized comparison found exactly four removed severity-2 react-hooks/exhaustive-deps unknown-rule records, zero additions, and no moved or changed records.
  • A fresh generated ledger byte-matches the committed .github/lint-baseline.json.

Verification

  • Frontend lint: 111 files / 113 errors / 6 warnings, exact ledger verified.
  • Frontend Jest: 727/727 passed; focused src/App.test.jsx: 310/310 passed.
  • CI workflow mutation tests: 7/7 passed; combined workflow/release/artifact/dependency suite: 54/54 passed.
  • SPA callback suite: 11/11 passed.
  • Functions lint passed; Functions Jest: 6,215 passed with 64 intentional skips.
  • Firestore Rules emulator on Java 17 / demo project: 378/378 passed.
  • Commerce command-journal emulator on Java 17 / demo project: 63/63 passed, including concurrent races.
  • Diagnostic production build compiled successfully.
  • Workflow YAML validation and git diff --check passed.

Review

Three independent adversarial reviews covered source semantics, exact-ledger integrity, documentation history, officer impact, and scope. Review found and corrected the same-UID user-projection wording in two comments and the 102→108→111 file-count chronology. All re-reviews are clean; no unresolved findings remain.

Closes #449

@netlify

netlify Bot commented Jul 22, 2026

Copy link
Copy Markdown

Deploy Preview for luminous-fox-7c393f ready!

Name Link
🔨 Latest commit 9becaad
🔍 Latest deploy log https://app.netlify.com/projects/luminous-fox-7c393f/deploys/6a60b121d2cc880008a7b733
😎 Deploy Preview https://deploy-preview-450--luminous-fox-7c393f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@daliu daliu left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review complete on exact head 9becaadc91b75790bdc00dda1fbd9976ae448394 against base 35240fa84efcda935b88eacbb0685e32aeb8ef10.

  • The hosted PR contains exactly the ten issue-owned paths and one commit.
  • Each TSX file changes only the specified comment line; executable output, effect bodies, dependency arrays, and line counts are unchanged.
  • The normalized ledger delta is exactly four removed records and zero added, moved, or changed records; the committed ledger byte-matches a fresh generation.
  • Three independent adversarial reviews covered source semantics, ledger integrity, test mutation resistance, documentation history, officer impact, and scope. Two wording/history findings were fixed and re-reviewed clean.
  • All required local Node 20 / Java 17 gates pass. No unresolved review issue remains.

This review proves source and local test state only. The Netlify result is a pull-request preview, not production publication; Firebase, providers, production data, and live behavior are unchanged and unverified.

@daliu
daliu merged commit 0b9960f into main Jul 22, 2026
9 checks passed
@daliu
daliu deleted the codex/issue-449-stale-hook-directives branch July 22, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI-001B4C — Retire the remaining stale exhaustive-deps directives

1 participant