Remove hard-coded PostgreSQL locale definitions from test fixtures#116
Open
yhong123 wants to merge 3 commits into
Open
Remove hard-coded PostgreSQL locale definitions from test fixtures#116yhong123 wants to merge 3 commits into
yhong123 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #115
This PR removes hard-coded PostgreSQL locale definitions from the following test fixtures:
/tests/examples/choice.sql/tests/examples/eav.sql/tests/examples/empty.sql/tests/examples/unique_generator.dump/tests/examples/instrument.sql/tests/examples/src.dump/tests/examples/dst.dump/tests/examples/tricky.sql/tests/examples/src2.dump/tests/examples/providers.dumpThe existing fixtures specify
LOCALE='en_US.utf8', which is not portable across platforms (e.g. macOS uses locale names such asen_US.UTF-8).PostgreSQL already inherits locale settings from the cluster, so the explicit locale specification is unnecessary.
I verified the change by running the test suite against PostgreSQL clusters initialised with several locales (
en_US.UTF-8,ja_JP.UTF-8,zh_CN.UTF-8), and the suite passed in all cases.