feat(design-system): define restrained radius and shape system - #477
Merged
IbrahimIjai merged 2 commits intoJul 29, 2026
Merged
Conversation
…SO4-Markets#395) - Replace undefined --radius base with explicit absolute values - Define sm (4px), md (6px), lg (8px), xl (12px), and full radius tokens - Document component-to-radius mapping for each token size - Remove broken calc() expressions that relied on undefined base - Existing Tailwind utilities (rounded-sm, rounded-md, etc.) now resolve correctly - All production components maintain their intended corner radius Implements DS-008 acceptance criteria: ✓ Scale defines sm, md, lg, xl, and full ✓ Component-to-radius mapping is documented ✓ Existing Tailwind radius utilities resolve from the scale ✓ No production component forced to unintentional square corners
|
@dev-susa is attempting to deploy a commit to the Ijai's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@dev-susa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements DS-008: Define a restrained radius and shape system (#395)
Replaces the broken radius scale (which relied on an undefined
--radiusbase variable) with explicit, absolute values that work correctly across all components.Changes
sm(4px),md(6px),lg(8px),xl(12px), andfullcalc()expressions that relied on undefined--radiusbaserounded-sm,rounded-md, etc.) now resolve correctlyComponent-to-Radius Mapping
Testing
@themeblockAcceptance Criteria
sm,md,lg,xl, andfullCloses #395