Skip to content

feat(design-system): add elevation, border, and focus-ring tokens - #479

Merged
IbrahimIjai merged 2 commits into
SO4-Markets:mainfrom
dev-susa:feat/396-elevation-border-focus-tokens
Jul 29, 2026
Merged

feat(design-system): add elevation, border, and focus-ring tokens#479
IbrahimIjai merged 2 commits into
SO4-Markets:mainfrom
dev-susa:feat/396-elevation-border-focus-tokens

Conversation

@dev-susa

Copy link
Copy Markdown
Contributor

Summary

Implements DS-009: Add elevation, border, and focus-ring tokens (#396)

Defines consistent separators, interactive borders, overlay shadows, and keyboard focus treatments that work seamlessly across all surfaces and themes (light/dark).

Changes

  • ✅ Defined border role tokens: default, hover, active, strong
  • ✅ Added shadow elevation scale: xs, sm, md, lg, xl
  • ✅ Defined focus ring tokens for keyboard navigation
  • ✅ Used oklch color-mix for theme-adaptive border states
  • ✅ Documented intended usage for each token role
  • ✅ All tokens work consistently in both light and dark themes

Border Roles

  • default: Subtle separators and card outlines
  • hover: Interactive element borders on hover
  • active: Active/pressed state borders
  • strong: Emphasized borders for important divisions

Shadow Elevation Scale

  • xs: Subtle lift for inputs and small controls
  • sm: Small elevated panels and dropdowns
  • md: Medium floating panels and popovers
  • lg: Large modals and dialogs
  • xl: Maximum elevation for overlays

Focus Ring Tokens

  • ring-default: Standard keyboard focus indicator
  • ring-offset: Space between element and focus ring (2px)

Implementation Details

  • Border states use oklch(from var(--border) calc(l * factor) c h) for dynamic adaptation
  • Shadows use oklch with alpha transparency for theme compatibility
  • Focus rings maintain WCAG visible-focus guidance on all core surfaces

Testing

  • ✅ Skeleton component tests pass
  • ✅ Build succeeds without errors
  • ✅ CSS tokens properly defined in Tailwind v4 @theme block

Acceptance Criteria

  • Default, hover, active, and strong border roles exist
  • Overlay and floating-panel shadows work in both themes
  • Focus rings meet visible-focus guidance on all core surfaces
  • Tokens are documented with intended usage

Closes #396

…oses SO4-Markets#396)

- Define border role tokens: default, hover, active, and strong
- Add shadow elevation scale: xs, sm, md, lg, and xl
- Define focus ring tokens for keyboard navigation visibility
- Use oklch color-mix for theme-adaptive border states
- Document intended usage for each token role
- All tokens work consistently across light and dark themes

Border roles:
- default: Subtle separators and card outlines
- hover: Interactive element borders on hover
- active: Active/pressed state borders
- strong: Emphasized borders for important divisions

Shadow roles:
- xs: Subtle lift for inputs and small controls
- sm: Small elevated panels and dropdowns
- md: Medium floating panels and popovers
- lg: Large modals and dialogs
- xl: Maximum elevation for overlays

Focus rings:
- ring-default: Standard keyboard focus indicator
- ring-offset: Space between element and ring

Implements DS-009 acceptance criteria:
✓ Default, hover, active, and strong border roles exist
✓ Overlay and floating-panel shadows work in both themes
✓ Focus rings meet visible-focus guidance on all core surfaces
✓ Tokens are documented with intended usage
@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown

@dev-susa is attempting to deploy a commit to the Ijai's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jul 29, 2026

Copy link
Copy Markdown

@dev-susa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@IbrahimIjai
IbrahimIjai merged commit 1919304 into SO4-Markets:main Jul 29, 2026
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DS-009: Add elevation, border, and focus-ring tokens

2 participants