feat(design-system): add elevation, border, and focus-ring tokens - #479
Merged
IbrahimIjai merged 2 commits intoJul 29, 2026
Merged
Conversation
…oses SO4-Markets#396) - Define border role tokens: default, hover, active, and strong - Add shadow elevation scale: xs, sm, md, lg, and xl - Define focus ring tokens for keyboard navigation visibility - Use oklch color-mix for theme-adaptive border states - Document intended usage for each token role - All tokens work consistently across light and dark themes Border roles: - default: Subtle separators and card outlines - hover: Interactive element borders on hover - active: Active/pressed state borders - strong: Emphasized borders for important divisions Shadow roles: - xs: Subtle lift for inputs and small controls - sm: Small elevated panels and dropdowns - md: Medium floating panels and popovers - lg: Large modals and dialogs - xl: Maximum elevation for overlays Focus rings: - ring-default: Standard keyboard focus indicator - ring-offset: Space between element and ring Implements DS-009 acceptance criteria: ✓ Default, hover, active, and strong border roles exist ✓ Overlay and floating-panel shadows work in both themes ✓ Focus rings meet visible-focus guidance on all core surfaces ✓ Tokens are documented with intended usage
|
@dev-susa is attempting to deploy a commit to the Ijai's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@dev-susa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements DS-009: Add elevation, border, and focus-ring tokens (#396)
Defines consistent separators, interactive borders, overlay shadows, and keyboard focus treatments that work seamlessly across all surfaces and themes (light/dark).
Changes
Border Roles
Shadow Elevation Scale
Focus Ring Tokens
Implementation Details
oklch(from var(--border) calc(l * factor) c h)for dynamic adaptationTesting
@themeblockAcceptance Criteria
Closes #396