102 feature implement booleanexpressionextensions#309
Merged
TanaseMariusatstarion merged 3 commits intoJun 23, 2026
Merged
Conversation
antoineatstariongroup
requested changes
Jun 23, 2026
| // therefore, just return the function as a predicate; if no function, will return null; | ||
| return booleanExpressionSubject == null | ||
| ? throw new ArgumentNullException(nameof(booleanExpressionSubject)) | ||
| : booleanExpressionSubject.ComputeFunction() as IPredicate; |
Collaborator
There was a problem hiding this comment.
This could silently fails in following case : If inside the "type" collection, we do have 2 elements, if the first one is a Function and the second one a Predicate, this method would return null even if it should return the second element. It's preferable to filter via the "type" collection directly and no call the ComputeFunction that already return the First element of type IFunction
…oleanExpressionSubject
|
antoineatstariongroup
approved these changes
Jun 23, 2026
TanaseMariusatstarion
deleted the
102-feature-implement-booleanexpressionextensions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fixed #102 implementation of BooleanExpression extension.