-
Notifications
You must be signed in to change notification settings - Fork 11
first commit #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Hester1937
wants to merge
18
commits into
main
Choose a base branch
from
Tong_Liu_CodeReview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
first commit #16
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
5677cb9
first commit
Hester1937 3c8109d
fix code
Hester1937 b5bde17
edit test case
Hester1937 51a9f95
edit testRestoreString5
Hester1937 65aea50
edit test case
Hester1937 dedb0b3
edit test case2
Hester1937 5c9476e
edit test case changes
Hester1937 ecedf0a
edit testcase change2
Hester1937 7623874
edit change3
Hester1937 6eef983
change remove
Hester1937 61a4cb7
edit testcase6
Hester1937 0ce6361
edit count
Hester1937 8777dc3
edit test case 7
Hester1937 9dd1e88
edit exception
Hester1937 7ebbb62
edit change
Hester1937 85743aa
delete file
Hester1937 c295ac7
fix code after peers review
Hester1937 ed462c1
fix code by delete
Hester1937 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,120 @@ | ||
| public class StringManipulation implements StringManipulationInterface { | ||
| private String string; | ||
|
|
||
| @Override | ||
| public String getString() { | ||
| return null; | ||
|
|
||
| return string; | ||
| } | ||
|
|
||
| @Override | ||
| public void setString(String string) { | ||
| this.string = string; | ||
| } | ||
|
|
||
| @Override | ||
| public int count() { | ||
| return 0; | ||
|
|
||
| if (this.string == null){ | ||
| throw new NullPointerException("NullPointerException"); | ||
| } | ||
|
|
||
| if (this.string.isEmpty()){ | ||
| return 0; | ||
| } | ||
|
|
||
| String[] result = this.string.split("\s+"); | ||
| int word = 0; | ||
| for (String current : result) { | ||
| if (!current.isEmpty()) { | ||
| word++; | ||
| } | ||
| } | ||
| return word; | ||
| } | ||
|
|
||
| @Override | ||
| public String removeNthCharacter(int n, boolean maintainSpacing) { | ||
| return null; | ||
|
|
||
| if (this.string == null || this.string.isEmpty()){ | ||
| throw new NullPointerException("NullPointerException"); | ||
| } | ||
| int length = string.length(); | ||
|
|
||
| if (n > string.length()) { | ||
| throw new IndexOutOfBoundsException("Out Of Bound"); | ||
| // System.out.println("Out Of Bound"); | ||
| } | ||
|
|
||
| if (n <= 0) { | ||
| throw new IllegalArgumentException("Invalid"); | ||
| } | ||
|
|
||
| StringBuilder result = new StringBuilder(); | ||
|
|
||
| for (int index = 0; index < length; index++) { | ||
| int compare = index + 1; | ||
|
|
||
| if (compare % n != 0) { | ||
| result.append(string.charAt(index)); | ||
|
|
||
| } else if (maintainSpacing == true) { | ||
| result.append(' '); | ||
| } | ||
| } | ||
| return result.toString(); | ||
| } | ||
|
|
||
| @Override | ||
| public String[] getSubStrings(int startWord, int endWord) { | ||
| return null; | ||
| if (startWord <= 0 || endWord <= 0 || startWord > endWord) { | ||
| throw new IllegalArgumentException("Invalid startWord or endWord"); | ||
| } | ||
| //String sentence = "This is an example sentence"; | ||
| String[] words = this.string.split(" "); | ||
|
|
||
| if (endWord > words.length) { | ||
| throw new IndexOutOfBoundsException("Not enough words in the sentence"); | ||
| } | ||
|
|
||
| String[] subStrings = new String[endWord - startWord + 1]; | ||
| int index = 0; | ||
|
|
||
| for (int i = startWord - 1; i < endWord; i++) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thank you Jonathan |
||
| subStrings[index] = words[i]; | ||
| index++; | ||
| } | ||
|
|
||
| return subStrings; | ||
| } | ||
|
|
||
|
|
||
| @Override | ||
| public String restoreString(int[] indices) { | ||
| return null; | ||
| } | ||
| if (this.string.isEmpty()){ | ||
| return ""; | ||
| } | ||
|
|
||
| if ( indices.length != string.length()) { | ||
| throw new IllegalArgumentException("Invalid"); | ||
| } | ||
|
|
||
| if (string == null || indices == null) { | ||
| throw new NullPointerException("NullPointerException"); | ||
| } | ||
|
|
||
| char[] restoredChars = new char[string.length()]; | ||
|
|
||
| for (int i = 0; i < indices.length; i++) { | ||
| int index = indices[i]; | ||
| if (index < 0 || index >= string.length()) { | ||
| throw new IndexOutOfBoundsException("Not enough words in the sentence"); | ||
| } | ||
| restoredChars[index] = string.charAt(i); | ||
| } | ||
|
|
||
| return new String(restoredChars); | ||
| } | ||
|
|
||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.