will_eand added Junit implementation#7
Conversation
|
I re-pushed after reviewing the changes FLSGawsi. I have a new commit to document these fixes for my Unit Assignment |
| @Override | ||
| public String getString() { | ||
| return null; | ||
| return message; |
There was a problem hiding this comment.
Naming: The variable names are meaningful and descriptive, making the code more readable.
| for (int i = 0; i < array.size(); i++) { | ||
| a = a + array.get(i); | ||
| } | ||
| return a; |
There was a problem hiding this comment.
The removeNthCharacter method correctly removes every nth character from the string while maintaining spacing as specified.
| for (int i = startWord - 1; i < endWord; i++) { | ||
| finalStringArray[count++] = tempStringArray[i]; | ||
| } | ||
| return finalStringArray; |
There was a problem hiding this comment.
There's an unnecessary conversion to an intermediate ArrayList that can be avoided by using an array directly.
| } | ||
| return finalString; | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Using a HashMap is a good approach to storing the character values associated with indices.
FLSGawsl
left a comment
FLSGawsl
left a comment
There was a problem hiding this comment.
Overall, the code implements the required functionality.
3 participants
this is a pull request?